Fix simSpawnObject argument count in the C++ client - #151
Open
megavedl wants to merge 1 commit into
Open
Conversation
The server binds six parameters and the client sent five, so every call failed on arity. The Python client already passes all six.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix simSpawnObject argument count in the C++ client
The C++ client sends five arguments, the server binds six, so every
simSpawnObject call from C++ fails on arity. It comes back as a generic
RPC error that says nothing about the cause, which makes it a slow one
to track down.
The Python client already passes all six (PythonClient/cosysairsim/client.py:779),
so this is just the C++ side being out of step. Looks like it goes back
to 19a7009, which added is_blueprint to the server and the Python
client but not here.
Passing false, matching the Python default. Left the C++ signature
alone to keep this to the bug; exposing is_blueprint there would be a
separate change.
Tested against Blocks on UE 5.8.2, Linux: before, every spawn from the
C++ client threw; after, actors spawn and keep the name they were asked
for. simDestroyObject removes them again.