test(ci): run example plugin suites after standalone core tests - #633
Open
be-student wants to merge 1 commit into
Open
test(ci): run example plugin suites after standalone core tests#633be-student wants to merge 1 commit into
be-student wants to merge 1 commit into
Conversation
Alishah634
requested review from
Alishah634
and removed request for
Alishah634
September 6, 2026 00:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Slice
What this PR does
Fixes #595. Root pytest discovery currently excludes the example plugins, so their own tests can regress while CI remains green. Add a Linux/Python 3.12 step that installs and tests each
examples/plugin-*package after the standalone core suite. Roottestpathsremains unchanged, and installation or pytest failures stop the step immediately. Future example packages are included by the same glob.README and CONTRIBUTING describe the sequence and recommend a separate local environment for example tests.
Tests added (run in CI)
tests/unit/test_example_plugin_ci.pyexecutes the actual CI shell with a local command shim: discovers a future example, preserves install-before-test order, and propagates failures from both commands. It also guards standalone-before-examples ordering and exclusion from root discovery. This shell-specific check skips Windows; the production step runs only on Linux.Final Linux validation used the official
python:3.12-bookwormimage, Xvfb, and an unprivileged runner user. Earlier macOS runs exposed environment differences (temporary-path entropy, color settings, nested venv inheritance, and Tk threading), and an initial root container run bypassed the unreadable-directory fixture's permissions. The final run corrects those execution conditions without changing application code or existing assertions.Changelog
changelog.d/README.md.Public-release safety (doberman-core only)
Security checklist
Edge cases covered / Deviations from plan / Risks introduced
Implemented with OpenAI Codex assistance.