Skip to content

fix(render): wrap non-path slash tokens - #657

Closed
be-student wants to merge 2 commits into
DobermanCore:mainfrom
be-student:fix/render/path-aware-wrap
Closed

fix(render): wrap non-path slash tokens#657
be-student wants to merge 2 commits into
DobermanCore:mainfrom
be-student:fix/render/path-aware-wrap

Conversation

@be-student

Copy link
Copy Markdown
Contributor

Pull Request

Slice

What this PR does

Force-breaks overlong ordinary tokens, including slash-bearing compound flags, while keeping Windows paths, POSIX paths, relative paths, URLs, and quoted Doberman commands intact.

Tests added (run in CI)

  • The issue-shaped compound flag stays within the 60-column clamp.
  • Windows, POSIX, relative, and URL tokens remain unbroken.

Changelog

  • changelog.d/<PR>.fixed.md fragment added in the follow-up commit

Public-release safety (doberman-core only)

  • Contains nothing from the "not allowed" list
  • Core still builds/tests/runs with no enterprise package installed

Security checklist

  • Fails closed on error / uncertainty
  • No secret, full file, or unredacted prompt logged or committed
  • No guardrail or learning behavior changed
  • BLOCK/AUTH behavior is unchanged
  • doberman-core does not import doberman_enterprise

Edge cases covered / Deviations from plan / Risks introduced

  • All 31 render tests and 553 CLI/setup/demo/telemetry consumer tests pass. Repository-wide lint, formatting, import contracts, links, parity, changelog compilation, and diff checks pass.
  • Implemented with Codex assistance; I reviewed the diff and validation results.

Closes #622

fu351 pushed a commit that referenced this pull request Sep 8, 2026
@fu351

fu351 commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Merged via a landing branch, thanks @be-student! Checking for the hidden-space marker before any path reasoning is the right order, it keeps an overlong quoted 'doberman ...' command on one line no matter what it contains, which is the one case the other fix for #622 missed. Nothing changed in your code: main now needs branches up to date and refuses merge commits, so I cherry-picked your commits onto main under your name and merged that. Next up for you is #656, I've left notes there on the one thing to change. Welcome to Doberman! Feel free to star the repo if it's been useful, and join the Discord if you have questions: https://discord.gg/Sfy5XGNqty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

render: the terminal wrap helper never force-breaks a non-path overlong word

2 participants