fix(render): wrap non-path slash tokens - #657
Closed
be-student wants to merge 2 commits into
Closed
Conversation
fu351
pushed a commit
that referenced
this pull request
Sep 8, 2026
(cherry picked from commit d155770)
Collaborator
|
Merged via a landing branch, thanks @be-student! Checking for the hidden-space marker before any path reasoning is the right order, it keeps an overlong quoted 'doberman ...' command on one line no matter what it contains, which is the one case the other fix for #622 missed. Nothing changed in your code: main now needs branches up to date and refuses merge commits, so I cherry-picked your commits onto main under your name and merged that. Next up for you is #656, I've left notes there on the one thing to change. Welcome to Doberman! Feel free to star the repo if it's been useful, and join the Discord if you have questions: https://discord.gg/Sfy5XGNqty |
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Slice
What this PR does
Force-breaks overlong ordinary tokens, including slash-bearing compound flags, while keeping Windows paths, POSIX paths, relative paths, URLs, and quoted Doberman commands intact.
Tests added (run in CI)
Changelog
changelog.d/<PR>.fixed.mdfragment added in the follow-up commitPublic-release safety (doberman-core only)
Security checklist
Edge cases covered / Deviations from plan / Risks introduced
Closes #622