Fix #733: rework preset creation to no longer use eval/exec - #734
Open
Dragorn421 wants to merge 1 commit into
Open
Fix #733: rework preset creation to no longer use eval/exec#734Dragorn421 wants to merge 1 commit into
Dragorn421 wants to merge 1 commit into
Conversation
Blender 5.1 updates python to 3.13 which changed some semantics around exec() modifying locals. Versioned code could have been used to do the simpler fix of doing exec(..., locals=locals()), but since modifying locals() in earlier versions of python had implementation-defined behavior we are better off just not even using exec nor eval at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blender 5.1 updates python to 3.13 which changed some semantics around exec() modifying locals.
Versioned code could have been used to do the simpler fix of doing exec(..., locals=locals()), but since modifying locals() in earlier versions of python had implementation-defined behavior we are better off just not even using exec nor eval at all.