fix(statedb): guard SubBalance against underflow; make ParseAmount de… - #20
Open
Leekyungun wants to merge 1 commit into
Open
fix(statedb): guard SubBalance against underflow; make ParseAmount de…#20Leekyungun wants to merge 1 commit into
Leekyungun wants to merge 1 commit into
Conversation
…nom-aware Backports cosmos/evm#1176. Adds an underflow guard to stateObject.SubBalance so a subtraction larger than the current balance panics (reverting the tx) instead of wrapping the uint256 balance to a near-max value. Also makes precompile bank-event amount parsing account for both the base and extended EVM-coin denoms. This closes the class of issue used to drain MANTRA (delegate() with a tiny amount triggering a balance underflow). Full fix is upstream cosmos/evm v0.6.2; recommend rebasing this fork onto v0.6.2 for the complete set of changes. Ref: cosmos/evm#1176
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports cosmos/evm#1176. Adds an underflow guard to stateObject.SubBalance so
a subtraction larger than the current balance panics (reverting the tx) instead
of wrapping the uint256 balance to a near-max value. Also makes precompile
bank-event amount parsing account for both the base and extended EVM-coin denoms.
This closes the class of issue used to drain MANTRA (delegate() with a tiny
amount triggering a balance underflow). Full fix is upstream cosmos/evm v0.6.2;
recommend rebasing this fork onto v0.6.2 for the complete set of changes.
Ref: cosmos/evm#1176