Skip to content

fix(statedb): guard SubBalance against underflow; make ParseAmount de… #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Leekyungun wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −3
Open

fix(statedb): guard SubBalance against underflow; make ParseAmount de… #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions precompiles/common/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,13 @@ func ParseAmount(event sdk.Event) (*uint256.Int, error) {
return nil, fmt.Errorf("failed to parse coins from %q: %w", amountAttr.Value, err)
}

amountBigInt := amountCoins.AmountOf(evmtypes.GetEVMCoinDenom()).BigInt()
amount, err := utils.Uint256FromBigInt(evmtypes.ConvertAmountTo18DecimalsBigInt(amountBigInt))
baseAmount := amountCoins.AmountOf(evmtypes.GetEVMCoinDenom()).BigInt()
amountBigInt := evmtypes.ConvertAmountTo18DecimalsBigInt(baseAmount)
if evmtypes.GetEVMCoinExtendedDenom() != evmtypes.GetEVMCoinDenom() {
extendedAmount := amountCoins.AmountOf(evmtypes.GetEVMCoinExtendedDenom()).BigInt()
amountBigInt = new(big.Int).Add(amountBigInt, extendedAmount)
}
amount, err := utils.Uint256FromBigInt(amountBigInt)
if err != nil {
return nil, fmt.Errorf("failed to convert coin amount to Uint256: %w", err)
}
Expand Down
12 changes: 11 additions & 1 deletion x/vm/statedb/state_object.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package statedb

import (
"bytes"
"fmt"
"math/big"
"sort"

Expand Down Expand Up @@ -147,7 +148,16 @@ func (s *stateObject) SubBalance(amount *uint256.Int) uint256.Int {
if amount.IsZero() {
return *(s.Balance())
}
return s.SetBalance(new(uint256.Int).Sub(s.Balance(), amount))
balance := s.Balance()
if balance.Lt(amount) {
panic(fmt.Sprintf(
"state balance underflow for %s: have=%s sub=%s",
s.address.Hex(),
balance.String(),
amount.String(),
))
}
return s.SetBalance(new(uint256.Int).Sub(balance, amount))
}

// SetBalance updates account balance.
Expand Down