[ARI:0001131, ARI:0001144, ARI:0001157, ARI:0001158, ARI:0001159, ARI:0001160] - mappings review - #83
Merged
Conversation
…:0001160] - mappings review
The `validate` job rejected this review batch with 19 errors, from two pre-existing gaps the batch was the first to expose. Morvan syndrome was created on 2026-07-02, before the metadata manager allocated sequential ids, so it kept a placeholder `#ARI_new_5199ce2a` IRI with no `ARI_ID` — the last such record in the ontology. Nothing noticed until this batch exported mapping rows for it and the empty subject reached both files spelled differently, `ARI:` on one side and empty on the other, so each file reported the other as missing the row. It gets `ARI:0001213` and the registry namespace every other disease uses. `ARI:0001158` lost DOID 0060234, umls C1275078, ncit C98873 and mesh C563187 through the disease record's field editor, which writes the ontology and nothing else — its changelog shows the four `Edited:` lines half an hour before the review was submitted. So four curated ids went without a judgment behind them, which is what `xref-deleted` is for. The replacements are right, so the four are flagged wrong in both exports rather than restored. The `mesh` NoTermFound row the review did write does not cover this: an absent-database verdict says nothing about the id that was previously stored. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Curator comment:
Submitted via the ARI Metadata Manager by @KrishnaTO.
Reviewed mappings
35 confirmed, 3 flagged, 15 no term in database — 53 new row(s) added to
mappings/ari.sssom.tsv(SSSOM) andmappings/ari.equivalencies.tsv. 19 confirmed id(s) also stored on the disease record itself. 1 flagged id(s) removed from the disease record itself.Changes
Mooren's ulcer (ARI:0001131)
Morvan syndrome (http://www.aurint.org/ontologies/ari-disease#ARI_new_5199ce2a)
Neuromyotonia (ARI:0001144)
Polyglandular autoimmune syndrome type 1 (ARI:0001157)
Polyglandular autoimmune syndrome type 2 (ARI:0001158)
Polyglandular autoimmune syndrome type 3 (ARI:0001159)
Polyglandular autoimmune syndrome type 4 (ARI:0001160)