Conversation
Keep creation, continuation, dispatch, and guide behavior behind a UI-independent Promise service. Record the staged attachment draft design and validation. Model: gpt-6
Model: gpt-6
Contributor
|
Desktop PR regression failed on commit
Recordings not attached
The Actions artifact retains the complete trace, screenshots, logs, and runtime evidence. |
This was referenced Sep 14, 2026
zxch3n
added this pull request to stack #713
September 14, 2026 17:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Stack 1/4 for attachment drafts. Base:
main. Subsequent layers will own resources, durable submission/delivery, and the complete draft experience.Problem / pressure
Creation, continuation, dispatch, and guide orchestration currently lives in a React hook. Deferred attachment sending needs to call the same path after the composer unmounts, without introducing another writer or changing upload timing during extraction.
Summary
Extract
createSessionSubmissionwith explicit admission and observation bindings. KeepuseSessionActionsas the React adapter and preserve existing routing, analytics timing, IDs, and acceptance behavior. Add the bilingual draft spec and owning decision note, including the separate scope for upload-free local references. This layer does not enable draft uploads or durable recovery.Visual explanation
Before / after
Test plan
pnpm checkrun stopped on one unchanged CLI worktree-GC assertion comparing macOS/varand/private/varaliases; 2,791 other CLI tests passed. Its full 11-test suite passed withTMPDIR=/private/tmp.pnpm formatran with unrelated changes discarded.Context handoff
Instructions for reviewing agents
session-submission.tswith the removed hook bodies, particularly initial metadata, config normalization, and guide promotion.Authoring context