fix(components): let the conversation title head the share dialog - #720
Merged
Merged
Conversation
The panel title sat at 15px while the public-link notice below it ran at 14px in full foreground, so the notice read as the primary line. Raise the title to 16px foreground and drop the notice to muted, matching the other hints on the screen. Model: claude-opus-5[1m]
The conversation being shared was the faintest line in the panel: 12px muted under a 15px "Share conversation" heading. Promote it to the header line (16px semibold foreground, truncated) and demote the action to a small muted label above it. Model: claude-opus-5[1m]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In the share-conversation dialog the conversation being shared — the one thing
that identifies what you are about to publish — was the faintest line on the
screen: 12px muted, under a 15px
Share conversationheading, with thepublic-link notice below it running at 14px in full
text-foreground.Header (
session-share-dialog.tsx):DialogTitle, 16px semiboldtext-foreground, truncated to one line and clear of the close button.Share conversationbecomes the small muted label above it (12px medium),carried by
DialogDescription.Body (
session-share-manager.tsx):publicNoticeline (both the plain and the globe/active shape) moves fromtext-foregroundtotext-muted-foreground, matching every other hint on thescreen, so it no longer competes with the header.
No copy, structure or behaviour changes. The first screen still states that
anyone with the link can view the conversation and that images are shared while
file attachments are not; the dialog keeps its fixed header over one scrolling
body, and its accessible name is still a
DialogTitlewith aDialogDescription.Before / After
Share conversationRendered from the
Sharing/SessionShareManagerstory props and checked in lightand dark, on the new-share and already-shared screens, plus a long title for the
truncation and close-button clearance.
Checks
NODE_ENV=development vitest runonsession-share-manager,session-share-surface,session-share-request-cards,session-access-control,session-share-mobile-menu— 32 passedtsc -p packages/components/tsconfig.json --noEmit— cleanprettier --checkon the touched files — clean🤖 Generated with Claude Code