Skip to content

fix(components): let the conversation title head the share dialog #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lodystage merged 2 commits into from
Sep 15, 2026
Merged

fix(components): let the conversation title head the share dialog #720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a10a18
fix(components): make the share dialog title outrank its notice
wibus-wee Sep 15, 2026
56843f6
fix(components): let the conversation title head the share dialog
wibus-wee Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions packages/components/src/components/sharing/session-share-dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,15 @@ export function SessionShareDialogFrame({
'calc(100dvh - var(--native-keyboard-height, 0px) - 2rem - var(--safe-area-top, 0px) - max(0px, var(--safe-area-bottom, 0px) - var(--native-keyboard-height, 0px)))',
}}
>
<DialogHeader className="shrink-0 gap-0.5 px-5 pb-3 pt-4 text-left">
<DialogTitle className="pr-7 text-[0.9375rem] font-semibold leading-6">
{/* The conversation being shared is the subject, so it carries the header:
the action reads as a small label above it, not as the larger line. */}
<DialogHeader className="shrink-0 gap-0.5 px-5 pb-3 pr-11 pt-4 text-left">
<DialogDescription className="text-xs font-medium text-muted-foreground">
{t('sharing.manager.title', 'Share conversation')}
</DialogTitle>
<DialogDescription className="truncate text-xs text-muted-foreground">
{title}
</DialogDescription>
<DialogTitle className="truncate text-base font-semibold leading-6 text-foreground">
{title}
</DialogTitle>
</DialogHeader>
<div
ref={body}
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/components/sharing/session-share-manager.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,14 +215,14 @@ export function SessionShareManager(props: SessionShareManagerProps) {
return (
<div className="space-y-3 px-5 pb-5 pt-1">
{active ? (
<div className="flex items-center gap-2 text-sm text-foreground">
<div className="flex items-center gap-2 text-sm text-muted-foreground">
<Globe className="size-4 shrink-0 text-muted-foreground" aria-hidden />
<span>
{t('sharing.static.publicNotice', 'Anyone with the link can view this conversation.')}
</span>
</div>
) : (
<p className="text-sm leading-6 text-foreground">
<p className="text-sm leading-6 text-muted-foreground">
{t('sharing.static.publicNotice', 'Anyone with the link can view this conversation.')}
</p>
)}
Expand Down
Loading