fix(mcp): rename the ngrok authtoken prompt for clarity - #448
Conversation
The ngrok install prompt was labeled "ngrok authtoken / MCP tunnel token", which read as if it were the endpoint's shared auth token (the MCP password) when it is actually the ngrok account token for the public tunnel. Rename it to "ngrok authtoken (account token from your ngrok dashboard)" so the two are not conflated.
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
![kody-ai[bot]](https://avatars.githubusercontent.com/in/413034?s=60&v=4){kind=small}
|
|
||
| // ngrokFields returns the promptable install fields for the ngrok provider: | ||
| // the authtoken / MCP tunnel token and the public base URL (MCP_PUBLIC_URL). | ||
| // the authtoken and the public base URL (MCP_PUBLIC_URL). |
There was a problem hiding this comment.
The comment references 'authtoken' and 'MCP_PUBLIC_URL', but the rule targets secret assignments or literals, not comments. No secret value is assigned here, so the line does not violate the rule.
Kody rule violation: Ban hard-coded secrets in Go source
Prompt for LLM
File internal/mcp/services/service_install_configurers.go:
Line 146:
The comment references 'authtoken' and 'MCP_PUBLIC_URL', but the rule targets secret assignments or literals, not comments. No secret value is assigned here, so the line does not violate the rule.
Talk to Kody by mentioning @kody
Was this suggestion helpful? React with 👍 or 👎 to help Kody learn from this interaction.
Code Coverage ReportTotal Coverage: 51.6% Generated from commit: edbdeb2 |
1 participant
What
The
pinner mcp installngrok prompt was labeled:That read as if it were the endpoint's shared auth token (the MCP password)
when it is actually the ngrok account token for the public tunnel — two
different secrets, one prompt.
Change
Rename the prompt to:
so the tunnel credential is not conflated with the MCP password (which is
collected separately in its own step).
Scope
internal/mcp/services/service_install_configurers.go:ngrokFieldspromptlabel (and its doc comment).
No behavior change; the value is still written to
MCP_TUNNEL_TOKEN/NGROK_AUTHTOKENand validated identically.internal/mcp/servicestests pass.Summary
This pull request clarifies the prompt text for the ngrok authtoken field during MCP service installation.
Changes
"ngrok authtoken / MCP tunnel token"to"ngrok authtoken (account token from your ngrok dashboard)".Purpose
The change improves user clarity by removing the potentially confusing "MCP tunnel token" terminology and providing more specific guidance by indicating the token comes from the ngrok dashboard. This makes it clearer to users what credential they need to provide during installation.