Skip to content

fix(mcp): rename the ngrok authtoken prompt for clarity #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pcfreak30 merged 1 commit into from
Aug 22, 2026
Merged

fix(mcp): rename the ngrok authtoken prompt for clarity #448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/mcp/services/service_install_configurers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ func cloudflaredFinalize(_ context.Context, _ fieldform.Prompter, s *ServiceInst
}

// ngrokFields returns the promptable install fields for the ngrok provider:
// the authtoken / MCP tunnel token and the public base URL (MCP_PUBLIC_URL).
// the authtoken and the public base URL (MCP_PUBLIC_URL).

@kody-ai kody-ai Bot Aug 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kody code-review Kody Rules low

The comment references 'authtoken' and 'MCP_PUBLIC_URL', but the rule targets secret assignments or literals, not comments. No secret value is assigned here, so the line does not violate the rule.

Kody rule violation: Ban hard-coded secrets in Go source

Prompt for LLM 

File internal/mcp/services/service_install_configurers.go:

Line 146:

The comment references 'authtoken' and 'MCP_PUBLIC_URL', but the rule targets secret assignments or literals, not comments. No secret value is assigned here, so the line does not violate the rule.

Talk to Kody by mentioning @kody

Was this suggestion helpful? React with 👍 or 👎 to help Kody learn from this interaction.

​

​

// Both resolve through a Derived hook so a re-run reuses what is already
// available (the config-manager store, the ngrok CLI config, the account API)
// instead of re-prompting, matching the legacy ngrokConfigurer it replaces.
Expand All @@ -158,7 +158,7 @@ func cloudflaredFinalize(_ context.Context, _ fieldform.Prompter, s *ServiceInst
// URL field is resolved.
func ngrokFields(ctx context.Context, cfgMgr config.Manager) []fieldform.Field[*ServiceInstallState, string] {
token := *installFieldByName("TunnelToken")
token.Prompt = promptText("ngrok authtoken / MCP tunnel token", "*")
token.Prompt = promptText("ngrok authtoken (account token from your ngrok dashboard)", "*")
token.Derived = func(s *ServiceInstallState) (string, bool) {
if s.TunnelToken != "" {
return s.TunnelToken, true
Expand Down
Loading