fix(ui): Settings polish: outline colour before first show, unset pan box outline (#326) - #327
Merged
Merged
Conversation
The Settings window appeared with DWM's default, stronger border until the WebView was ready and ApplyWindowTheme ran; it now runs before ShowWindow. Version 0.20.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KPUNAWcwghXdHCApcKKjSG
[Set modifiers + Arrow keys] used the borderless ghost style of the Add key buttons; it shows a key combination, so it now has the chipb outline of the other binding boxes (teal while recording). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KPUNAWcwghXdHCApcKKjSG
Maxaubert
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #326. Version 0.20.1.
ApplyWindowTheme(border colour + background) only ran once the controller existed. It now also runs right afterCreateWindowExW, beforeShowWindow.[Set modifiers + Arrow keys]used the borderless ghost style of the Add key buttons; it now keeps the outline of the other binding boxes (teal while recording).Playwright 157 pass;
build.bat configbuilds; deployed and checked on the dev box. Unsigned (no SignPath enrollment yet).🤖 Generated with Claude Code
https://claude.ai/code/session_01KPUNAWcwghXdHCApcKKjSG