Skip to content

fix(ui): Settings polish: outline colour before first show, unset pan box outline (#326) #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maxaubert merged 2 commits into from
Oct 2, 2026
Merged

fix(ui): Settings polish: outline colour before first show, unset pan box outline (#326) #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b5937e
fix(config): set the window outline colour before the first show (#326)
Maxaubert Oct 2, 2026
7011845
fix(ui): the unset pan box keeps the key box outline (#326)
Maxaubert Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/config_ui/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,8 +888,11 @@ int WINAPI wWinMain(HINSTANCE hInst, HINSTANCE, PWSTR lpCmdLine, int) {
int wx = wa.left + ((wa.right - wa.left) - ww) / 2;
int wy = wa.top + ((wa.bottom - wa.top) - wh) / 2;
SetWindowPos(hwnd, nullptr, wx, wy, ww, wh, SWP_NOZORDER);
ShowWindow(hwnd, SW_SHOW);
// Outline colour and background BEFORE the first show (#326): the window used to appear with DWM's default,
// stronger border until the WebView was ready and ApplyWindowTheme ran.
g_hwnd = hwnd;
ApplyWindowTheme();
ShowWindow(hwnd, SW_SHOW);
g_onboard = onboard;
CreateWebView(hwnd);
MSG msg; while (GetMessageW(&msg, nullptr, 0, 0)) { TranslateMessage(&msg); DispatchMessageW(&msg); }
Expand Down
4 changes: 2 additions & 2 deletions src/version.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

#define WIND_VER_MAJOR 0
#define WIND_VER_MINOR 20
#define WIND_VER_PATCH 0
#define WIND_VER_PATCH 1

// String form for logs/snapshot/UI. Keep in sync with the numeric parts above.
#define WIND_VERSION_STR "0.20.0"
#define WIND_VERSION_STR "0.20.1"
2 changes: 1 addition & 1 deletion ui/src/controls/PanBinding.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@

<div class="bx" role="group" aria-labelledby={labelledby && labelledby.split(' ')[0]} aria-describedby={describedby}>
{#if state.kind === 'none'}
<button type="button" class="kc ghost" class:live={armed} {disabled} id={valueId}
<button type="button" class="kc ghost pan" class:live={armed} {disabled} id={valueId}
aria-label={armed ? 'Recording pan modifiers' : 'Set pan modifiers'}
aria-describedby="{describedby ?? ''} {uid}-hint"
onclick={arm} onblur={() => cancel()}>
Expand Down
2 changes: 1 addition & 1 deletion ui/src/controls/Preview.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
const visible = (r) => !r.showIf || String(values[r.showIf.key]) === String(r.showIf.eq);
const set = (key, val) => { values[key] = val; calls.push([key, val]); };
const extra = {
runningModel: 'hybrid', mpoNeedsRestart: false, version: '0.20.0',
runningModel: 'hybrid', mpoNeedsRestart: false, version: '0.20.1',
onRestart: () => calls.push('restart'), onAction: (a) => calls.push(['action', a]),
onRepo: () => calls.push('repo'),
pick: async () => 'RDR2.exe',
Expand Down
5 changes: 4 additions & 1 deletion ui/src/controls/bindings.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@
.bx .kc.ghost { border-color: transparent; color: var(--fg3); gap: 5px; cursor: pointer; }
.bx .kc.ghost:hover { color: var(--fg); border-color: var(--chipb); }
.bx .kc.ghost svg { width: 11px; height: 11px; flex: none; fill: none; stroke: currentColor; stroke-width: 1.75; stroke-linecap: round; stroke-linejoin: round; }
.bx .kc.live { color: var(--fg); border-color: var(--fill); }
/* The unset pan box shows a key combination, so it keeps the outline of the other key boxes (Max 2026-10-02). */
.bx .kc.ghost.pan { border-color: var(--chipb); }
.bx .kc.ghost.pan:hover { border-color: var(--outline); }
.bx .kc.live, .bx .kc.ghost.pan.live { color: var(--fg); border-color: var(--fill); }
.bx .kc .kp { color: var(--glyph); margin: 0 5px; font-family: var(--s); }
.bx .kc .kfix { display: inline-flex; align-items: center; gap: 5px; color: var(--fg3); }
.bx .kc .kfix svg { width: 13px; height: 13px; flex: none; fill: none; stroke: currentColor; stroke-width: 1.6; }
Expand Down
Loading