pcre2test: fix off-by-one heap write in pattern expand buffer - #966
Open
sage-mode-hunter wants to merge 1 commit into
Open
pcre2test: fix off-by-one heap write in pattern expand buffer#966sage-mode-hunter wants to merge 1 commit into
sage-mode-hunter wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The expand pattern modifier can fill pbuffer8 to its exact size and then write the terminating zero one byte past the end:
/\[a]{50000}/expand(50000 is the default pbuffer8 size) overflows the buffer by one byte; ASAN reports a heap-buffer-overflow WRITE of size 1 in process_pattern\[...]{n}replicator lower in the same file already reserves the byte with>=