Skip to content

pcre2test: fix off-by-one heap write in pattern expand buffer #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sage-mode-hunter wants to merge 1 commit into
base: main
Choose a base branch
from
Open

pcre2test: fix off-by-one heap write in pattern expand buffer #966

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pcre2test_inc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2289,7 +2289,7 @@ else if ((pat_patctl.control & CTL_EXPAND) != 0)
expanding buffers always keeps buffer and pbuffer8 in step as far as their
size goes. */

while (pt + count * length > pbuffer8 + pbuffer8_size)
while (pt + count * length >= pbuffer8 + pbuffer8_size)
{
size_t pc_offset = pc - buffer;
size_t pp_offset = pp - buffer;
Expand Down
Loading