✅ test(release): restore the changelog gate — main is red on a vacuous note grep and a subject-shaped merge proof - #44
Merged
Conversation
…not the bare token The bare `pins.toolDigest` token is not header-unique — two commit subjects in the [0.2.0] section carry it verbatim and cliff.toml names it again in the D-121 note — so the note greps matched the rendered BODY and passed whether or not the header note survived. Section 6's polarity control failed closed on exactly that vacuity, which is what took `task check` red on main.
…t prefix D-136 skips merges by `merge_commit` shape, but 7a asserted every bullet only the mutant renders starts with `- Merge `. A merge carrying a conventional gitmoji subject (41a3072, landed with PR #38) is skipped correctly and was misread as an over-skip. Membership in `git log --merges` is also strictly stronger the other way: a non-merge commit merely titled "Merge …" now fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis red: therelease-exitgatejob's AUD-S18 audit exit gate runstask check, which dies inrelease-changelog-gate-test. Two distinct defects, one commit each.1. §1/§6 — the D-120 note grep was vacuous
The greps keyed on the bare token
pins.toolDigest. That token is not header-unique: two commit subjects inside the[0.2.0]section carry it verbatim (warn record consumers that pins.toolDigest changed value,derive pins.toolDigest from Go build info), andcliff.tomlnames it again in the D-121 note. So the grep matched the rendered body and passed whether or not the header note survived.§6's polarity control detected precisely this and failed closed — the control did its job. Fixed by anchoring on the header sentence
pins.toolDigest` changes value after. Measured, not reasoned:--latest--latest --strip header2. §7a — the merge-skip proof was keyed on subject text
D-136 skips merges by commit shape (
merge_commit = true), but 7a asserted every bullet only the mutant renders starts with- Merge. Real history now carries a merge with a conventional gitmoji subject —41a3072 :twisted_rightwards_arrows: chore(aud-s18): merge AUD-S13 (PR #35), landed with #38 — which is skipped correctly and was misread as an over-skip. That case is exactly the accepted cost §7b already pins in its sandbox.Now keyed on membership in
git log --merges, which is also strictly stronger in the other direction: an ordinary commit merely titled "Merge …" would have satisfied the old grep and now fails.Gates
bash hack/release/changelog_gate_test.sh— exit 0, all 8 sections, both polaritiesCI=true bash hack/audit/exitgate_test.sh— exit 0, all 14 stages (this runs a fulltask check)Run locally because
release-exitgateisskippingon pull requests — PR CI will not exercise either gate. That is RELSE-08, and it is why #38 merged green and reddenedmain.