π‘οΈ Sentinel: [HIGH] Fix hardcoded HMAC secret salt in webhook payload signing - #5
Conversation
Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
π¨ Severity: HIGH
π‘ Vulnerability: Hardcoded HMAC secret salt
"idsec_secret_salt"inserver/routes.tsused for webhook payload signing.π― Impact: Attackers reading the codebase could compute valid HMAC signatures and forge test webhook payloads.
π§ Fix: Replaced hardcoded secret string with environment variable lookups (
process.env.IDSEC_SECRET_SALT || process.env.WEBHOOK_SECRET) and added inline security comments.β Verification: Verified code modifications, ran lint checks, and passed code review.
PR created automatically by Jules for task 3227534910150307569 started by @Pmaster-dev