Skip to content

🛡️ Sentinel: [HIGH] Fix hardcoded HMAC secret salt in webhook payload signing #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pmaster-dev wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🛡️ Sentinel: [HIGH] Fix hardcoded HMAC secret salt in webhook payload signing #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08cd4ea
security: make webhook HMAC secret salt configurable via env vars
google-labs-jules[bot] Sep 5, 2026
89c4c5a
security: make webhook HMAC secret salt configurable via env vars
google-labs-jules[bot] Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .jules/sentinel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Sentinel Security Journal

## 2026-09-03 - Configurable HMAC Salt for Webhook Signatures
**Vulnerability:** Hardcoded secret salt `"idsec_secret_salt"` used in `server/routes.ts` for HMAC webhook payload signing.
**Learning:** Hardcoded cryptographic keys in API routes leak secrets in open source code and enable payload signature forgery.
**Prevention:** Always pull HMAC secret salts from environment variables (`IDSEC_SECRET_SALT` / `WEBHOOK_SECRET`) with non-production development fallbacks.
4 changes: 3 additions & 1 deletion server/routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2453,7 +2453,9 @@ CSAF: ${baseUrl}/.well-known/csaf/provider-metadata.json
// Create webhook payload with cryptographic signature
const payloadId = uuidv4();
const payloadString = JSON.stringify(data);
const signature = crypto.createHmac("sha256", "idsec_secret_salt").update(payloadString).digest("hex");
// Security: Avoid hardcoded secrets in production. Use environment variables with safe dev fallback.
const secretSalt = process.env.IDSEC_SECRET_SALT || process.env.WEBHOOK_SECRET || "negrarosa_dev_webhook_secret_salt";
const signature = crypto.createHmac("sha256", secretSalt).update(payloadString).digest("hex");

const payload = {
id: payloadId,
Expand Down
Loading