Skip to content

🛡️ Sentinel: Fix hardcoded HMAC secret key in webhook signatures - #8

Open
Pmaster-dev wants to merge 1 commit into
mainfrom
fix/idsec-hmac-secret-salt-3182088694070061025
Open

🛡️ Sentinel: Fix hardcoded HMAC secret key in webhook signatures#8
Pmaster-dev wants to merge 1 commit into
mainfrom
fix/idsec-hmac-secret-salt-3182088694070061025

Conversation

@Pmaster-dev

Copy link
Copy Markdown
Owner

Fixes hardcoded HMAC secret key vulnerability in webhook processing.


PR created automatically by Jules for task 3182088694070061025 started by @Pmaster-dev

Replaces hardcoded HMAC secret key used in webhook payload signing with process.env.IDSEC_SECRET_SALT and throws an error if missing in production.

Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant