Skip to content

🛡️ Sentinel: Fix hardcoded HMAC secret key in webhook signatures #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pmaster-dev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🛡️ Sentinel: Fix hardcoded HMAC secret key in webhook signatures #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion server/routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2453,7 +2453,12 @@ CSAF: ${baseUrl}/.well-known/csaf/provider-metadata.json
// Create webhook payload with cryptographic signature
const payloadId = uuidv4();
const payloadString = JSON.stringify(data);
const signature = crypto.createHmac("sha256", "idsec_secret_salt").update(payloadString).digest("hex");
// Security: Require environment variable for HMAC secret key in production to prevent static key exposure
const secretSalt = process.env.IDSEC_SECRET_SALT;
if (!secretSalt && process.env.NODE_ENV === "production") {
throw new Error("IDSEC_SECRET_SALT environment variable is required in production");
}
const signature = crypto.createHmac("sha256", secretSalt || "development_idsec_secret_salt").update(payloadString).digest("hex");

const payload = {
id: payloadId,
Expand Down
Loading