fix: request Q10 maps through dpMultiMap#901
Open
tubededentifrice wants to merge 1 commit into
Open
Conversation
This was referenced Jul 25, 2026
tubededentifrice
marked this pull request as ready for review
July 25, 2026 14:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Independent transport slice extracted from #900. Q10 map refreshes now use the protocol's asynchronous
dpMultiMaplist/get exchange and wait for the matchingMAP_RESPONSEpacket before publishing an update.Why
dpRequestDpsrefreshes ordinary Q10 status values, but it does not reliably cause every Q10 firmware version to publish its map. That left callers waiting for a packet that might never arrive, or falling back to an old cached map eventhough the rest of the device state had refreshed.
Map retrieval uses a separate protocol flow:
dpMultiMapwithop: listdpMultiMapwithop: getfor the selected IDMAP_RESPONSEThe implementation must therefore remain asynchronous;
getacknowledges the request but does not contain the map itself. We also wait for a real map or trace packet rather than any trait update, because status/restriction changes can re-render the cached image and must not be mistaken for a fresh map response. Concurrent requests are coalesced because the firmware throttles map pushes, and an expected command failure is contained so it cannot terminate the persistent subscription loop.Changes
dpMultiMaplist → get →MAP_RESPONSERoborockExceptionat the refresh boundarythrough the observable map subscription API
Validation
pytest -q— 886 passed, 86 snapshots passedpre-commit run --files ...— all hooks passedRelationship to #900
This PR is independent and targets
main. The rendering work is split into #902, #903, and #904; #900 remains the aggregate real-device/Home Assistant before-and-after reference.