refactor: render Q10 overlays with V1#903
Draft
tubededentifrice wants to merge 2 commits into
Draft
Conversation
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second rendering slice extracted from #900, stacked on #902. Q10 overlays now reuse the V1 image generator for paths, robot/dock markers, zones, and virtual walls while Q10 parsing remains responsible for converting protocol coordinates into
MapData.Changes
Before / after
The same isolated
MapDatafixture is rendered before and after this slice.Validation
pytest -q— 885 passed, 86 snapshots passedpre-commit run --files ...— all hooks passedStack / review order
GitHub cannot target an upstream PR at a branch that exists only in a fork, so this PR temporarily targets
mainand includes #902 in Files changed. The independent incremental diff is:tubededentifrice/python-roborock@vc/q10-v1-palette...vc/q10-v1-overlays
After #902 merges, this PR can be rebased onto
mainwithout changing its review boundary. The transport correction is independent in #901; #900 remains the aggregate real-device/Home Assistant reference.