Shard PRISM coordinator tests by domain - #73
Open
kiwidream wants to merge 1 commit into
Open
Conversation
kiwidream
force-pushed
the
prism-test-shards
branch
from
July 22, 2026 13:50
920a2e6 to
d8a99b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Position in the stack
PR 1 of 9. Base:
1.x.x. Next: PR 74.Review this PR against its configured base. Retargeting a later PR to
1.x.xwould show the cumulative stack instead of one review slice. The complete order is in the stack guide.Why this slice exists
The production refactor needs domain-focused regression suites. Splitting the monolithic coordinator tests first gives every later ownership extraction a small, discoverable test boundary without mixing test movement into its production diff.
What changes
No production code changes in this PR.
Why the diff is large
GitHub reports roughly 14,300 additions and 14,200 deletions across 21 files because one large test file was split many ways. A many-to-many split cannot be represented as a simple rename, so unchanged test bodies appear as deleted from the old file and added to new shards.
The substantive review surface is limited to fixture/import rewiring and the three unused-import removals. Review the new shard boundaries and shared support modules first, then verify that test cases were moved rather than weakened or dropped.
Review focus
Validation
git diff --checkpassed.Landing note
Merge review slices bottom-up if they are landed individually. If the stack is collapsed for release history, preserve these PRs as the review record and build the integration change from a refreshed target base.
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Note
Low Risk
Test-only refactor with no production paths modified; risk is limited to accidental test loss or fixture drift during the split.
Overview
Splits the monolithic PRISM coordinator unittest file into domain-focused suites (e.g. block candidates, config, job cache, tip refresh) so later refactors can hang tests on clear boundaries instead of one huge module.
Adds
tests/prism_coordinator_test_support.pyandtests/prism_vardiff_test_support.pywith shared no-environment fakes (FakeRpc,FakeLedger,coordinator()builders, audit-bundle stubs, vardiff helpers). Shards import these via star-imports or explicit imports instead of duplicating setup in each file.No production/runtime changes. Touch-ups only: drop a few unused imports in CTV broadcaster and compose-profile tests.
The large line count is mostly move-only test bodies; review the new file boundaries and that shared fixtures keep the same defaults (e.g.
tip_refresh_failure_holdoff_seconds = 0.0for monotonic-frozen tests).Reviewed by Cursor Bugbot for commit d8a99b5. Bugbot is set up for automated code reviews on this repo. Configure here.