fix: stop reading secret UNIT_AURA payload (v8.0.4)

[DonnieDice]

Fixed

Midnight 12.1 marks \updateInfo.addedAuras\ as \ConditionalSecretContents. BLU v8.0.3 iterated it directly, causing repeated callback errors propagated through the RGX event dispatcher.

Changes

• Remove direct \UNIT_AURA\ registration and \updateInfo.addedAuras\ access
• Route proc handling through \RGXCombat:OnProc\
• Route Lust/Heroism detection through \RGXAuras:HasPlayerAura\ with edge detection (\hadLust\ flag)
• Add \Subscribe/\Cleanup\ lifecycle to prevent duplicate callbacks on module disable/re-enable
• Bump version to \�8.0.4\
• Add Lua 5.1 regression test
• Add GitHub CI workflow for Lua syntax + regression tests
• Exclude \ ests/\ from player package via .pkgmeta\

Verification

• 41 Lua files, 0 syntax errors
• RGX audit: 0 findings on Combat.lua
• Lua 5.1 regression fixture: 5 proc callbacks, 2 lust gains, clean reinit
• BigWigs packager dry-run: v8.0.4, tests excluded, no unsafe aura access

Requires RGX-Framework v2.5.1 or later.

Summary by CodeRabbit

• Bug Fixes

  • Fixed repeated aura-related errors on Midnight.
  • Improved detection of proc effects and Lust/Heroism gains, including preventing duplicate notifications.
  • Improved cleanup and reinitialization of combat tracking.

• Compatibility

  • Requires RGX-Framework version 2.5.1 or later.
  • Updated the addon interface to version 8.0.4.

• Documentation

  • Added release notes describing the combat and aura handling updates.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 371e2783-0aa0-4473-b41b-d2c622be49c0

📥 Commits

Reviewing files that changed from the base of the PR and between bffb459 and 06916b5.

📒 Files selected for processing (7)

• .github/workflows/ci.yml
• .pkgmeta
• BLU.toc
• docs/CHANGES.md
• docs/changelogs/8.0.4.md
• modules/Combat/Combat.lua
• tests/combat-secret-aura-test.lua

---

📝 Walkthrough

Walkthrough

BLU migrates combat and aura handling to RGX-Framework callbacks, adds secret-aura regression coverage and CI validation, excludes tests from packages, and publishes version 8.0.4 release metadata.

Changes

Combat callback migration and release

Layer / File(s)	Summary
RGX combat subscriptions and aura handling modules/Combat/Combat.lua	The combat module uses RGX combat and aura services. It replaces legacy events with callbacks, detects Lust gains through aura state, and tracks callback cleanup.
Secret-aura regression coverage and CI execution tests/combat-secret-aura-test.lua, .github/workflows/ci.yml	The regression test validates protected aura handling, proc sounds, cleanup, and reinitialization. CI runs Lua 5.1 syntax checks and the regression test.
Release metadata and package contents BLU.toc, docs/CHANGES.md, docs/changelogs/8.0.4.md, .pkgmeta	The addon version and changelogs identify release 8.0.4 and require RGX-Framework v2.5.1 or later. Packaging excludes tests.

Estimated code review effort: 4 (Complex) | ~45 minutes

Sequence Diagram(s)

sequenceDiagram
  participant CombatModule
  participant RGXCombat
  participant RGXAuras
  participant SoundPlayback
  CombatModule->>RGXCombat: subscribe to combat callbacks
  RGXCombat->>CombatModule: invoke proc callback
  CombatModule->>RGXAuras: HasPlayerAura
  RGXAuras-->>CombatModule: return Lust state
  CombatModule->>SoundPlayback: play lust_sound on Lust gain

Loading

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/blu-secret-aura-v8.0.4

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}