Skip to content

"Replace ROCm driver with amdgpu driver keyword" - #306

Closed
anilkubn wants to merge 1 commit into
ROCm:mainfrom
anilkubn:patch-4
Closed

"Replace ROCm driver with amdgpu driver keyword"#306
anilkubn wants to merge 1 commit into
ROCm:mainfrom
anilkubn:patch-4

Conversation

@anilkubn

Copy link
Copy Markdown
Contributor

Motivation

The objective is to make changes to our web presence in order to build the Instinct GPU brand and update the messaging related to the ROCm driver.

Technical Details

Test Plan

Test Result

Submission Checklist

yansun1996 added a commit to yansun1996/gpu-operator-rocm that referenced this pull request Aug 3, 2026
Completes the terminology fix across docs/. This occurrence in
upgrading.md was not covered by ROCm#303, ROCm#304, ROCm#305, or ROCm#306.

Co-Authored-By: Claude <noreply@anthropic.com>
@yansun1996

Copy link
Copy Markdown
Member

Thanks @anilkubn! The text this PR edits (the Radeon-repo version-mismatch limitation) no longer exists on main, so this change is now stale and can't be applied. The overall "ROCm driver" → "amdgpu driver" cleanup across the current docs is handled in #620. Closing this one out.

@yansun1996 yansun1996 closed this Aug 3, 2026
yansun1996 added a commit to yansun1996/gpu-operator-rocm that referenced this pull request Aug 3, 2026
Completes the terminology fix across docs/. This occurrence in
upgrading.md was not covered by ROCm#303, ROCm#304, ROCm#305, or ROCm#306.

Co-Authored-By: Claude <noreply@anthropic.com>
sajmera-pensando pushed a commit that referenced this pull request Aug 4, 2026
* Replace ROCm driver with amdgpu driver keyword

* "Replace ROCm driver with amdgpu driver keyword"

* docs: replace "ROCm driver" with "amdgpu driver" in upgrading guide

Completes the terminology fix across docs/. This occurrence in
upgrading.md was not covered by #303, #304, #305, or #306.

Co-Authored-By: Claude <noreply@anthropic.com>

* "Replace ROCm driver with amdgpu driver keyword"

* "Replace ROCm driver with amdgpu driver keyword"

* docs: address review comments on amdgpu driver terminology

Fixes from Copilot review on PR #1637:
- upgrading.md: "amdgpu drivers version" -> "amdgpu driver versions"
- installation.md: link label "See ROCm Versions" -> "See amdgpu Versions"
  to match the amdgpu-docs link target
- releasenotes.md / knownlimitations.md: typo "need to specific" -> "specify"

Co-Authored-By: Claude <noreply@anthropic.com>

* docs: fix markdownlint MD060 table alignment in installation.md

The "ROCm" -> "amdgpu" label change (+2 chars) shifted the table
pipes out of alignment with the header, failing the docs-lint e2e
target. Trim 2 padding spaces in the version cell to realign.

Verified: markdownlint-cli2 v0.22.0 --config docs/.markdownlint.yaml
reports 0 errors.

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: anilkubn <anilkubn@amd.com>
Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants