docs: replace "ROCm driver" with "amdgpu driver" keyword - #620
Merged
sajmera-pensando merged 7 commits intoAug 4, 2026
Conversation
This was referenced Aug 3, 2026
yansun1996
force-pushed
the
docs/rocm-to-amdgpu-driver
branch
from
August 3, 2026 18:25
9081713 to
aa605eb
Compare
Fixes from Copilot review on PR #1637: - upgrading.md: "amdgpu drivers version" -> "amdgpu driver versions" - installation.md: link label "See ROCm Versions" -> "See amdgpu Versions" to match the amdgpu-docs link target - releasenotes.md / knownlimitations.md: typo "need to specific" -> "specify" Co-Authored-By: Claude <noreply@anthropic.com>
The "ROCm" -> "amdgpu" label change (+2 chars) shifted the table pipes out of alignment with the header, failing the docs-lint e2e target. Trim 2 padding spaces in the version cell to realign. Verified: markdownlint-cli2 v0.22.0 --config docs/.markdownlint.yaml reports 0 errors. Co-Authored-By: Claude <noreply@anthropic.com>
bhatnitish
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates the "ROCm driver" → "amdgpu driver" terminology fix across all of
docs/, replacing four fragmented single-file PRs (#303, #304, #305, #306) from @anilkubn with one PR.The out-of-tree kernel module the operator installs is the amdgpu driver; "ROCm driver" was imprecise wording.
Commits
main— an unrelated change to theimagerow — has been resolved.)docs/drivers/upgrading.md, an occurrence not addressed by any of the four original PRs.Why #305 / #306 are not included
Those PRs edited the "Radeon-repo version-mismatch" limitation text in
docs/releasenotes.mdanddocs/knownlimitations.md. That text no longer exists onmain, so those changes are stale/no-ops. They can be closed.Verification
grep -rni "ROCm driver" docs/returns no matches after this change.Files changed
docs/drivers/precompiled-driver.md(from Replace ROCm driver with amdgpu driver keyword #303)docs/drivers/installation.md(from "Replace ROCm driver with amdgpu driver keyword" #304)docs/drivers/upgrading.md(new)Supersedes #303, #304, #305, #306.
🤖 Generated with Claude Code