Skip to content

feat: confirm pharmacy deletion and migrate models - #19

Closed
Roman-Andr wants to merge 5 commits into
mainfrom
dev
Closed

feat: confirm pharmacy deletion and migrate models#19
Roman-Andr wants to merge 5 commits into
mainfrom
dev

Conversation

@Roman-Andr

@Roman-Andr Roman-Andr commented Aug 19, 2026

Copy link
Copy Markdown
Owner

Impact

  • adds a per-pharmacy delete button on the right side of every row
  • requires a second click within five seconds: the cross changes to a check mark, then resets if deletion is not confirmed
  • removes the selected pharmacy instead of only the final row
  • migrates all production and test data models from dataclasses to Pydantic models
  • preserves immutable model behavior with frozen models and rejects unknown fields

Root cause

Pharmacy rows had no targeted delete action or confirmation state; the only existing action removed the last row immediately. Structured models were also split between Pydantic and dataclasses, which left validation and copy semantics inconsistent across the application.

Validation

  • uv lock --check
  • uv run ruff check .
  • uv run mypy
  • env -u DISPLAY -u WAYLAND_DISPLAY uv run pytest - 330 passed, 16 GUI tests skipped locally because Xvfb is unavailable
  • uv run pyinstaller --noconfirm pharmparser.spec
  • ./dist/pharmparser-cli --help

Screenshots

A local screenshot is not attached because this release environment has no working display server or Xvfb. The delete-button behavior has unit and GUI regression coverage; the GitHub Linux job runs the GUI suite under Xvfb.

@Roman-Andr

Copy link
Copy Markdown
Owner Author

Superseded by #20: GitHub marked the shared dev history as non-rebaseable. #20 contains the byte-for-byte identical checked tree on a clean main base, so the required rebase merge can proceed without rewriting dev.

@Roman-Andr Roman-Andr closed this Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant