feat: confirm pharmacy deletion and migrate models - #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Impact
Root cause
Pharmacy rows had no targeted delete action or confirmation state; the only existing action removed the last row immediately. Structured models were also split between Pydantic and dataclasses, which left validation and copy semantics inconsistent across the application.
Validation
uv lock --checkuv run ruff check .uv run mypyenv -u DISPLAY -u WAYLAND_DISPLAY uv run pytest- 330 passed, 16 GUI tests skipped locally because Xvfb is unavailableuv run pyinstaller --noconfirm pharmparser.spec./dist/pharmparser-cli --helpScreenshots
A local screenshot is not attached because this release environment has no working display server or Xvfb. The delete-button behavior has unit and GUI regression coverage; the GitHub Linux job runs the GUI suite under Xvfb.
Release workflow note
This supersedes #19. GitHub reported the shared
devhistory asrebaseable: falsebecause it contains merge commits. This branch is based directly on the samemainSHA and its tree is byte-for-byte identical to the checkeddevhead, allowing the required rebase merge without rewritingdev.