Skip to content

feat: confirm pharmacy deletion and migrate models - #20

Merged
Roman-Andr merged 1 commit into
mainfrom
feat/confirmed-pharmacy-deletion
Aug 19, 2026
Merged

feat: confirm pharmacy deletion and migrate models#20
Roman-Andr merged 1 commit into
mainfrom
feat/confirmed-pharmacy-deletion

Conversation

@Roman-Andr

Copy link
Copy Markdown
Owner

Impact

  • adds a per-pharmacy delete button on the right side of every row
  • requires a second click within five seconds: the cross changes to a check mark, then resets if deletion is not confirmed
  • removes the selected pharmacy instead of only the final row
  • migrates all production and test data models from dataclasses to Pydantic models
  • preserves immutable model behavior with frozen models and rejects unknown fields

Root cause

Pharmacy rows had no targeted delete action or confirmation state; the only existing action removed the last row immediately. Structured models were also split between Pydantic and dataclasses, which left validation and copy semantics inconsistent across the application.

Validation

  • uv lock --check
  • uv run ruff check .
  • uv run mypy
  • env -u DISPLAY -u WAYLAND_DISPLAY uv run pytest - 330 passed, 16 GUI tests skipped locally because Xvfb is unavailable
  • uv run pyinstaller --noconfirm pharmparser.spec
  • ./dist/pharmparser-cli --help

Screenshots

A local screenshot is not attached because this release environment has no working display server or Xvfb. The delete-button behavior has unit and GUI regression coverage; the GitHub Linux job runs the GUI suite under Xvfb.

Release workflow note

This supersedes #19. GitHub reported the shared dev history as rebaseable: false because it contains merge commits. This branch is based directly on the same main SHA and its tree is byte-for-byte identical to the checked dev head, allowing the required rebase merge without rewriting dev.

@Roman-Andr
Roman-Andr merged commit c462e93 into main Aug 19, 2026
4 checks passed
@Roman-Andr
Roman-Andr deleted the feat/confirmed-pharmacy-deletion branch August 19, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant