Support 2.0.x spec generation - #10
anurag6569201 wants to merge 1 commit into
Conversation
Source PR: appwrite#13497 Source head: 4176480
|
| description: "Appwrite version to generate specs for" | ||
| required: true | ||
| options: | ||
| - "2.0.x" |
There was a problem hiding this comment.
Shipwright · HIGH
The workflow input options and the SDKs task validation list are updated independently.
Impact: The workflow input options and the SDKs task validation list are updated independently. If a future version is added to one location but not the other, the workflow will offer a choice that the task rejects with 'Unknown version given', or the task will accept a version that cannot be selected in the UI. These two lists are now duplicated state with no shared source of truth.
Suggested fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.
| description: "Appwrite version to generate specs for" | ||
| required: true | ||
| options: | ||
| - "2.0.x" |
There was a problem hiding this comment.
Shipwright · LOW
The version lists are hardcoded in two separate files with no comment or test linking them.
Impact: The version lists are hardcoded in two separate files with no comment or test linking them. A new contributor adding 2.1.x would not know both locations must be updated, and there is no automated check to catch drift.
Suggested fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.
What does this PR do?
Adds
2.0.xto the SDK example generator and specs workflow now that Appwrite 2.0.0 is released.Validation
php -l src/Appwrite/Platform/Tasks/SDKs.php--version=2.0.xRelated to CLO-4377.
Source merge-base:
6b5bc9b6eb168eb8c371ce56fb6c2b8c0d4f054fSource head:
4176480f5d8bd88fc831575ed277bfb66abff894