Skip to content

Support 2.0.x spec generation - #10

Open
anurag6569201 wants to merge 1 commit into
qa/agent-appwrite-appwrite/pr-10-13497/basefrom
qa/agent-appwrite-appwrite/pr-10-13497/head
Open

anurag6569201 wants to merge 1 commit into
qa/agent-appwrite-appwrite/pr-10-13497/basefrom
qa/agent-appwrite-appwrite/pr-10-13497/head

Conversation

@anurag6569201

Copy link
Copy Markdown

What does this PR do?

Adds 2.0.x to the SDK example generator and specs workflow now that Appwrite 2.0.0 is released.

Validation

  • php -l src/Appwrite/Platform/Tasks/SDKs.php
  • generated all configured SDK examples with --version=2.0.x

Related to CLO-4377.

Source merge-base: 6b5bc9b6eb168eb8c371ce56fb6c2b8c0d4f054f
Source head: 4176480f5d8bd88fc831575ed277bfb66abff894

@shipwright-agent

Copy link
Copy Markdown

⚠️ Shipwright · Approve with conditions

Recommendation: approve PR #10 with conditions · Tier T3
Checks: 0 total · 0 needing attention

Next step: an authorized approver must satisfy the approval condition.

Findings (3)

  • HIGH The workflow input options and the SDKs task validation list are updated independently. · .github/workflows/specs.yml:14
    • Fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.
  • LOW The version lists are hardcoded in two separate files with no comment or test linking them. · .github/workflows/specs.yml:14
    • Fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.
  • LOW No security-relevant change is introduced by adding version strings, but the duplicated allowlist pattern is a maintainability risk that could later lead to an unvalidated version · src/Appwrite/Platform/Tasks/SDKs.php:146
    • Fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.

Conditions

  • human approval required (T3): apply the approval label

Fireworks usage: 5,337 input · 338 output · 5,675 total tokens · $0.0014 · 8s · 0 fix iteration(s)

Open the Shipwright check for full evidence and the audit bundle. Use /shipwright rerun to verify again.

description: "Appwrite version to generate specs for"
required: true
options:
- "2.0.x"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shipwright · HIGH

The workflow input options and the SDKs task validation list are updated independently.

Impact: The workflow input options and the SDKs task validation list are updated independently. If a future version is added to one location but not the other, the workflow will offer a choice that the task rejects with 'Unknown version given', or the task will accept a version that cannot be selected in the UI. These two lists are now duplicated state with no shared source of truth.

Suggested fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.

description: "Appwrite version to generate specs for"
required: true
options:
- "2.0.x"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shipwright · LOW

The version lists are hardcoded in two separate files with no comment or test linking them.

Impact: The version lists are hardcoded in two separate files with no comment or test linking them. A new contributor adding 2.1.x would not know both locations must be updated, and there is no automated check to catch drift.

Suggested fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant