Skip to content

Support 2.0.x spec generation #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anurag6569201 wants to merge 1 commit into
base: qa/agent-appwrite-appwrite/pr-10-13497/base
Choose a base branch
from
Open

Support 2.0.x spec generation #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/specs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ on:
description: "Appwrite version to generate specs for"
required: true
options:
- "2.0.x"

@shipwright-agent shipwright-agent Bot Sep 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shipwright · HIGH

The workflow input options and the SDKs task validation list are updated independently.

Impact: The workflow input options and the SDKs task validation list are updated independently. If a future version is added to one location but not the other, the workflow will offer a choice that the task rejects with 'Unknown version given', or the task will accept a version that cannot be selected in the UI. These two lists are now duplicated state with no shared source of truth.

Suggested fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.

@shipwright-agent shipwright-agent Bot Sep 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shipwright · LOW

The version lists are hardcoded in two separate files with no comment or test linking them.

Impact: The version lists are hardcoded in two separate files with no comment or test linking them. A new contributor adding 2.1.x would not know both locations must be updated, and there is no automated check to catch drift.

Suggested fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.

- "1.9.x"
- "1.8.x"
- "1.7.x"
- "1.6.x"
Expand Down
1 change: 1 addition & 0 deletions src/Appwrite/Platform/Tasks/SDKs.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ public function action(?string $platform, ?string $sdk, ?string $version, ?strin
'1.7.x',
'1.8.x',
'1.9.x',
'2.0.x',
'latest',
])) {
throw new \Exception('Unknown version given');
Expand Down
Loading