Show the Invest catalog to everyone, not just existing holders - #2518
Merged
Merged
Conversation
Gating the whole Invest section on holdings left anyone with a zero xStock balance looking at an Earn page that ends after the vault tiles — no heading, no catalog, no way in. The section that sells you your first stock was only visible once you already owned one. The escape hatch the gate assumed — "discovery depends entirely on the Stocks tab" — does not exist on qa. The desktop sidebar's NAV_ITEMS is a hardcoded Wallet/Earn/Rewards/Activity, and the redesigned bottom bar reads WHITELIST_TAB_NAMES, which is index/earn/rewards. Neither lists Stocks, so /stocks is reachable only by typing it. So the gate moves off the section and onto the positions panel, which is the part that actually has nothing to say when you hold nothing. The panel keeps its isHoldingsLoading hold-back so it doesn't appear and then vanish; the catalog is no longer behind that, because it has nothing to wait for and a 164-token mainnet multicall is a slow thing to block a page on. One consequence worth naming: useXStockHoldings defaults data to [] on error, so a failed multicall is indistinguishable from holding nothing. Before this it silently hid the whole section from a genuine holder. Now it costs them only the positions panel. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gating the whole Invest section on holdings left anyone with a zero xStock balance looking at an Earn page that ends after the vault tiles — no heading, no catalog, no way in. The section that sells you your first stock was only visible once you already owned one.
The escape hatch the gate assumed — "discovery depends entirely on the Stocks tab" — does not exist on qa. The desktop sidebar's NAV_ITEMS is a hardcoded Wallet/Earn/Rewards/Activity, and the redesigned bottom bar reads WHITELIST_TAB_NAMES, which is index/earn/rewards. Neither lists Stocks, so /stocks is reachable only by typing it.
So the gate moves off the section and onto the positions panel, which is the part that actually has nothing to say when you hold nothing. The panel keeps its isHoldingsLoading hold-back so it doesn't appear and then vanish; the catalog is no longer behind that, because it has nothing to wait for and a 164-token mainnet multicall is a slow thing to block a page on.
One consequence worth naming: useXStockHoldings defaults data to [] on error, so a failed multicall is indistinguishable from holding nothing. Before this it silently hid the whole section from a genuine holder. Now it costs them only the positions panel.