Skip to content

Show the Invest catalog to everyone, not just existing holders #2518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mul53 merged 1 commit into from
Sep 14, 2026
Merged

Show the Invest catalog to everyone, not just existing holders #2518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 33 additions & 23 deletions components/Earn/EarnInvestSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,36 +153,46 @@ export const EarnInvestSection = () => {
collapse();
};

// The whole section is for people who already hold something, so it is absent
// rather than empty for everyone else. Held back while the holdings read is in
// flight too: appearing and then vanishing reads worse than arriving late.
if (isHoldingsLoading || holdings.length === 0) return null;
// The positions panel is for people who already hold something, so it is absent
// rather than empty for everyone else, and held back while the holdings read is
// in flight: appearing and then vanishing reads worse than arriving a beat late.
//
// The catalog below is deliberately not gated on it. It is the only route from
// Earn into buying a first stock, so it has to render for holders and
// non-holders alike, and it must not wait on a chain read to do so.
const hasPositions = !isHoldingsLoading && holdings.length > 0;

return (
<View className="mt-8">
<Text className="text-[18px] font-semibold leading-6 text-white">Invest</Text>
<Text className="mt-1 text-[14px] leading-5 text-white/50">Your positions</Text>

<View className="mt-4 overflow-hidden rounded-[20px] bg-[#1C1C1C] px-4 py-2">
{holdings.map(holding => {
const token = tokensBySymbol.get(holding.ticker);
const price = prices[holding.ticker];
{hasPositions && (
<>
<Text className="mt-1 text-[14px] leading-5 text-white/50">Your positions</Text>

return (
<EarnAssetRow
key={holding.ticker}
ticker={holding.ticker}
name={formatAssetName(holding.ticker, holding.name)}
caption={formatShares(holding.shares)}
logoUrl={token?.logoUrl}
value={price === undefined ? undefined : holding.shares * price}
onPress={() => token && openStock(token, 'sell')}
/>
);
})}
</View>
<View className="mt-4 overflow-hidden rounded-[20px] bg-[#1C1C1C] px-4 py-2">
{holdings.map(holding => {
const token = tokensBySymbol.get(holding.ticker);
const price = prices[holding.ticker];

return (
<EarnAssetRow
key={holding.ticker}
ticker={holding.ticker}
name={formatAssetName(holding.ticker, holding.name)}
caption={formatShares(holding.shares)}
logoUrl={token?.logoUrl}
value={price === undefined ? undefined : holding.shares * price}
onPress={() => token && openStock(token, 'sell')}
/>
);
})}
</View>
</>
)}

<Text className="mt-6 text-[14px] leading-5 text-white/50">
{/* Falls back to the section's subtitle slot when nothing sits above it. */}
<Text className={`text-[14px] leading-5 text-white/50 ${hasPositions ? 'mt-6' : 'mt-1'}`}>
Buy, sell and use as collateral
</Text>

Expand Down
Loading