ADFA-2602: Correct version references in plugin docs and metadata comments - #1648
Open
Daniel-ADFA wants to merge 1 commit into
Open
ADFA-2602: Correct version references in plugin docs and metadata comments#1648Daniel-ADFA wants to merge 1 commit into
Daniel-ADFA wants to merge 1 commit into
Conversation
…ments PLUGIN_AUTHORING.md told plugin authors to request AGP 8.11.0 and Kotlin 1.9.22 for an on-device build. The harvested localMvnRepository now ships AGP 9.3.1 and Kotlin 2.3.21, so those instructions produced an unresolvable build. The apiVersion/languageVersion pins in common, eventbus-events, idetooltips and plugin-api stay at 2.0. Their comments named 1.9.22 as the reason, which no longer holds; the real invariant is that the jar must stay readable by every supported on-device compiler, including a device still on an older bundled toolchain after a KOTLIN_VERSION bump. Reworded to say that instead of naming a version that will keep going stale.
Daniel-ADFA
marked this pull request as ready for review
August 11, 2026 13:58
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
itsaky-adfa
reviewed
Aug 11, 2026
| dev/CI repo resolves online. A plugin built **on-device** resolves AGP and the Kotlin | ||
| Gradle plugin from the harvested on-device `localMvnRepository`, which currently ships | ||
| only **AGP `8.11.0`** and **Kotlin `1.9.22`**. Request those versions for an on-device | ||
| only **AGP `8.13.1`** and **Kotlin `2.3.0`**. Request those versions for an on-device |
Contributor
There was a problem hiding this comment.
appdevforall/dev-assets#57 upgrades to AGP 9. Is 8.13.1 the correct version here?
Contributor
Author
There was a problem hiding this comment.
Ah! Thanks for catching that, I was iterating for compatibility and forgot to update the docs on the plugin end, I'll update it. It's AGP 9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLUGIN_AUTHORING.md told plugin authors to request AGP 8.11.0 and Kotlin
1.9.22 for an on-device build. The harvested localMvnRepository now ships
AGP 9.3.1 and Kotlin 2.3.21, so those instructions produced an
unresolvable build.
The apiVersion/languageVersion pins in common, eventbus-events,
idetooltips and plugin-api stay at 2.0. Their comments named 1.9.22 as the
reason, which no longer holds; the real invariant is that the jar must stay
readable by every supported on-device compiler, including a device still on
an older bundled toolchain after a KOTLIN_VERSION bump. Reworded to say
that instead of naming a version that will keep going stale.
Stack created with GitHub Stacks CLI • Give Feedback 💬