Skip to content

ADFA-2602: Correct version references in plugin docs and metadata comments #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Daniel-ADFA wants to merge 1 commit into from
Open

ADFA-2602: Correct version references in plugin docs and metadata comments #1648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ android {
kotlin {
compilerOptions {
// This module's classes ship in the plugin-api coordinate that on-device plugins
// compile against, so emit metadata the on-device Kotlin (1.9.22) can read (<= 2.0.0).
// compile against, so emit metadata every supported on-device Kotlin can read (<= 2.0.0).
apiVersion.set(org.jetbrains.kotlin.gradle.dsl.KotlinVersion.KOTLIN_2_0)
languageVersion.set(org.jetbrains.kotlin.gradle.dsl.KotlinVersion.KOTLIN_2_0)
}
Expand Down
6 changes: 3 additions & 3 deletions docs/PLUGIN_AUTHORING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,16 +71,16 @@ injected `com.itsaky.androidide.plugins.build` `1.0.0` marker.
The `plugins {}` example above uses AGP `8.8.2` / Kotlin `2.1.21` — the versions the
dev/CI repo resolves online. A plugin built **on-device** resolves AGP and the Kotlin
Gradle plugin from the harvested on-device `localMvnRepository`, which currently ships
only **AGP `8.11.0`** and **Kotlin `1.9.22`**. Request those versions for an on-device
only **AGP `8.13.1`** and **Kotlin `2.3.0`**. Request those versions for an on-device

@itsaky-adfa itsaky-adfa Aug 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appdevforall/dev-assets#57 upgrades to AGP 9. Is 8.13.1 the correct version here?

@Daniel-ADFA Daniel-ADFA Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Thanks for catching that, I was iterating for compatibility and forgot to update the docs on the plugin end, I'll update it. It's AGP 9

build, or offline resolution of the build plugins fails.

Also declare AGP `apply false` in the **root** `build.gradle.kts` (as the standard CoGo
project template does):

```kotlin
plugins {
id("com.android.application") apply false version "8.11.0"
id("com.android.library") apply false version "8.11.0"
id("com.android.application") apply false version "8.13.1"
id("com.android.library") apply false version "8.13.1"
}
```

Expand Down
2 changes: 1 addition & 1 deletion eventbus-events/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ android {
kotlin {
compilerOptions {
// This module's classes ship in the plugin-api coordinate that on-device plugins
// compile against, so emit metadata the on-device Kotlin (1.9.22) can read (<= 2.0.0).
// compile against, so emit metadata every supported on-device Kotlin can read (<= 2.0.0).
apiVersion.set(org.jetbrains.kotlin.gradle.dsl.KotlinVersion.KOTLIN_2_0)
languageVersion.set(org.jetbrains.kotlin.gradle.dsl.KotlinVersion.KOTLIN_2_0)
}
Expand Down
2 changes: 1 addition & 1 deletion idetooltips/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ android {
kotlin {
compilerOptions {
// This module's classes ship in the plugin-api coordinate that on-device plugins
// compile against, so emit metadata the on-device Kotlin (1.9.22) can read (<= 2.0.0).
// compile against, so emit metadata every supported on-device Kotlin can read (<= 2.0.0).
apiVersion.set(org.jetbrains.kotlin.gradle.dsl.KotlinVersion.KOTLIN_2_0)
languageVersion.set(org.jetbrains.kotlin.gradle.dsl.KotlinVersion.KOTLIN_2_0)
}
Expand Down
3 changes: 2 additions & 1 deletion plugin-api/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ android {
kotlin {
compilerOptions {
jvmTarget.set(org.jetbrains.kotlin.gradle.dsl.JvmTarget.JVM_17)
// Emit metadata the on-device Kotlin compiler (1.9.22) can read (<= 2.0.0).
// Emit metadata every supported on-device Kotlin compiler can read (<= 2.0.0), so a
// device still on an older bundled toolchain keeps working after a KOTLIN_VERSION bump.
// This jar ships in the plugin-api coordinate on-device plugins compile against.
apiVersion.set(org.jetbrains.kotlin.gradle.dsl.KotlinVersion.KOTLIN_2_0)
languageVersion.set(org.jetbrains.kotlin.gradle.dsl.KotlinVersion.KOTLIN_2_0)
Expand Down
Loading