test: bump @vscode/test-electron to ^3.1.0 to fix macOS insiders CI - #153
Merged
Merged
Conversation
The 'test macOS (18.x, insiders)' job fails repo-wide (incl. on main) with 'spawn .../Contents/MacOS/Electron ENOENT': the pinned @vscode/test-electron 2.3.8 (2023) can't locate the executable in the current VS Code Insiders macOS build. Bump to the latest Node-18-safe line (2.5.2). Note: the newest @vscode/test-electron (3.0.0) would be the most complete fix but requires Node >=22 (CI runs Node 18) and restructures the internal out/runTest import, so it is out of scope here. If 2.5.2 does not fully resolve the insiders job, the follow-up is a coordinated Node 22 + test-electron 3.0.0 upgrade.
laileni-aws
changed the title
The 'test macOS (18.x, insiders)' job fails repo-wide with 'spawn .../Visual Studio Code - Insiders.app/Contents/MacOS/Electron ENOENT': @vscode/test-electron 2.x resolves an executable path that current VS Code Insiders macOS builds no longer use. Fixed in test-electron 3.x. - Bump ^2.5.2 -> ^3.1.0 (matches upstream aws-toolkit-vscode) - Import TestOptions/runTests from the package root; drop the internal '@vscode/test-electron/out/runTest' path No CI Node bump needed: .npmrc sets engine-strict=false, so 3.x (engines: node>=22) installs on the Node 18 runners, matching upstream.
laileni-aws
changed the title
laileni-aws
marked this pull request as ready for review
July 30, 2026 22:21
chungjac
approved these changes
Jul 30, 2026
laileni-aws
enabled auto-merge (squash)
July 30, 2026 23:10
ashishrp-aws
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
test macOS (18.x, insiders)job fails repo-wide (onmainand on unrelated PRs, e.g. #204) with:@vscode/test-electron2.x resolves a macOS Insiders executable path that current Insiders builds no longer use. Bumping within the 2.x line (2.3.8 → 2.5.2) does not fix it —2.5.2is the last 2.x release (2024) and predates the layout change (CI-confirmed).Fix
Bump
@vscode/test-electron^2.5.2 → ^3.1.0— the line that handles the current Insiders macOS layout. This mirrors upstreamaws/aws-toolkit-vscode, which already ships^3.1.0.package.json:@vscode/test-electron→^3.1.0packages/core/scripts/test/launchTestUtilities.ts: importTestOptions/runTestsfrom the package root and drop the internal@vscode/test-electron/out/runTestpath (the root export is the public API in 3.x).package-lock.json: regenerated (integrity matches the registry).No CI Node bump required
An earlier revision of this PR assumed 3.x forces a Node 18 → 22 CI migration. It does not:
.npmrcsetsengine-strict=false, so 3.x (engines: node>=22) installs on the Node 18 runners.aws-toolkit-vscodeships@vscode/test-electron@^3.1.0while keeping macOS/Linux CI on Node 18.Verification
npm installresolves@vscode/test-electron@3.1.0(integrity matches registry).tsc -p packages/core/tsconfig.json --noEmit→ 0 errors (the import restructure type-checks).