Skip to content

Fix camera setup review follow-ups - #21

Merged
berginj merged 1 commit into
mainfrom
codex/fix-review-followups
Jul 22, 2026
Merged

Fix camera setup review follow-ups#21
berginj merged 1 commit into
mainfrom
codex/fix-review-followups

Conversation

@berginj

@berginj berginj commented Jul 22, 2026

Copy link
Copy Markdown
Owner

What changed

  • points the documentation index to the current v2 FAQ
  • replaces obsolete rolling-shutter webcam purchasing guidance with an evidence-first global-shutter qualification profile
  • makes legacy pipeline camera defaults backend-aware: OpenCV uses indexes 0/1, while UVC and simulator backends retain logical IDs left/right
  • adds regression tests for backend defaults and explicit overrides

Why

These changes address the still-valid review findings on PR #8 and PR #6. The old hardware guide could direct field testers toward unsuitable rolling-shutter cameras, and the OpenCV CLI failed at startup when its backend was selected without explicit camera indexes.

Validation

  • 40 focused camera and CLI tests passed
  • Flake8 passed repository-wide with zero findings
  • file-length gate passed
  • schema mirror check passed
  • changed-document local links resolve
  • git diff --check passed

Review references

@berginj
berginj marked this pull request as ready for review July 22, 2026 12:38
@berginj
berginj merged commit 211d246 into main Jul 22, 2026
3 checks passed
@berginj
berginj deleted the codex/fix-review-followups branch July 22, 2026 12:38

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 40ea2ebbb1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/pipeline.py
Comment on lines +42 to +45
if args.left is None:
args.left = "0" if args.backend == "opencv" else "left"
if args.right is None:
args.right = "1" if args.backend == "opencv" else "right"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Map legacy lane ROIs when defaulting OpenCV IDs

When --backend opencv is used without explicit IDs, these defaults change the runtime camera IDs to 0/1; if the operator still has a legacy configs/lane_roi.json keyed by left/right, load_lane_polygon() only checks the exact runtime IDs and silently falls back to the centered ROI. That makes the newly fixed default OpenCV path ignore saved lane calibration for those rigs, so either map the legacy left/right entries onto the numeric defaults or reuse the existing runtime ROI loader that has that fallback.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant