Skip to content

Fix camera setup review follow-ups #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
berginj merged 1 commit into from
Jul 22, 2026
Merged

Fix camera setup review follow-ups #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions app/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,16 @@ def parse_args() -> argparse.Namespace:
"--backend",
choices=("uvc", "opencv", "sim"),
default="uvc",
help="Capture backend to use (opencv or sim).",
help="Capture backend to use (uvc, opencv, or sim).",
)
parser.add_argument("--left", default="left", help="Left camera ID or index.")
parser.add_argument("--right", default="right", help="Right camera ID or index.")
return parser.parse_args()
parser.add_argument("--left", default=None, help="Left camera ID or index.")
parser.add_argument("--right", default=None, help="Right camera ID or index.")
args = parser.parse_args()
if args.left is None:
args.left = "0" if args.backend == "opencv" else "left"
if args.right is None:
args.right = "1" if args.backend == "opencv" else "right"
Comment on lines +42 to +45

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Map legacy lane ROIs when defaulting OpenCV IDs

When --backend opencv is used without explicit IDs, these defaults change the runtime camera IDs to 0/1; if the operator still has a legacy configs/lane_roi.json keyed by left/right, load_lane_polygon() only checks the exact runtime IDs and silently falls back to the centered ROI. That makes the newly fixed default OpenCV path ignore saved lane calibration for those rigs, so either map the legacy left/right entries onto the numeric defaults or reuse the existing runtime ROI loader that has that fallback.

Useful? React with 👍 / 👎.

return args


def build_lane_gate(
Expand Down
Loading
Loading