Skip to content

core: services: ping: Keep port watcher running after unexpected errors - #4040

Closed
joaoantoniocardoso wants to merge 1 commit into
masterfrom
fix/ping-port-watcher-resilience
Closed

core: services: ping: Keep port watcher running after unexpected errors#4040
joaoantoniocardoso wants to merge 1 commit into
masterfrom
fix/ping-port-watcher-resilience

Conversation

@joaoantoniocardoso

@joaoantoniocardoso joaoantoniocardoso commented Jul 27, 2026

Copy link
Copy Markdown
Member

Summary

  • Catch unexpected errors in the Ping PortWatcher loop so discovery keeps running.
  • Add a regression test that a transient add_ping360 failure does not stop watching.

Follow-up to #4036: that PR fixes the list_ips() KeyError, but any other uncaught exception in the watch loop still permanently kills sensor discovery because sensor_manager() is started with a bare asyncio.create_task.

Test plan

  • pytest core/services/ping/test_portwatcher.py
  • Confirm Ping service continues discovering after SoftAP/uap0 churn on a vehicle

@joaoantoniocardoso

Copy link
Copy Markdown
Member Author

Superseded by #4051 (same changes, head moved to fork joaoantoniocardoso/BlueOS-docker).

@joaoantoniocardoso

Copy link
Copy Markdown
Member Author

Closed in favor of #4051.

@joaoantoniocardoso
joaoantoniocardoso deleted the fix/ping-port-watcher-resilience branch July 27, 2026 21:03
@joaoantoniocardoso joaoantoniocardoso removed the move-to-stable Needs to be cherry-picked and move to stable label Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant