core: services: ping: Keep port watcher running after unexpected errors - #4040
Closed
joaoantoniocardoso wants to merge 1 commit into
Closed
core: services: ping: Keep port watcher running after unexpected errors#4040joaoantoniocardoso wants to merge 1 commit into
joaoantoniocardoso wants to merge 1 commit into
Conversation
This was referenced Jul 27, 2026
Member
Author
|
Superseded by #4051 (same changes, head moved to fork |
Member
Author
|
Closed in favor of #4051. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PortWatcherloop so discovery keeps running.add_ping360failure does not stop watching.Follow-up to #4036: that PR fixes the
list_ips()KeyError, but any other uncaught exception in the watch loop still permanently kills sensor discovery becausesensor_manager()is started with a bareasyncio.create_task.Test plan
pytest core/services/ping/test_portwatcher.pyuap0churn on a vehicle