core: services: ping: Keep port watcher running after unexpected errors - #4051
Draft
joaoantoniocardoso wants to merge 1 commit into
Draft
Conversation
2 tasks
Automated PR Review0. Summary
Wraps the body of No further comments, nice job 👍 Generated by PR Review Bot. This is advisory, a human reviewer must still approve. |
joaoantoniocardoso
marked this pull request as draft
July 27, 2026 21:34
joaoantoniocardoso
force-pushed
the
fix/ping-port-watcher-resilience
branch
from
July 28, 2026 01:34
b3d7d9f to
d6c8308
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PortWatcherloop so discovery keeps running.add_ping360failure does not stop watching.Follow-up to #4036: that PR fixes the
list_ips()KeyError, but any other uncaught exception in the watch loop still permanently kills sensor discovery becausesensor_manager()is started with a bareasyncio.create_task.Test plan
pytest core/services/ping/test_portwatcher.pyuap0churn on a vehicleSupersedes #4040 (recreated from fork
joaoantoniocardoso/BlueOS-dockerinstead of same-repo head).