Superbuild: static half only — drop the ADD_MODULE_LIB shared twin - #26
Merged
Conversation
Found by the daslang fat-man gate on its first real (daslang_static) link: the superbuild branch built both halves of ADD_MODULE_LIB, but the shared twin of an imgui-family module cannot link on Windows (no IMGUI_API dllexport matrix across the pair, no glfw import lib) — and nothing ever loads it: in a superbuild the DLL flavor comes from this module's own standalone build (daspkg). Static half only, matching what an embedded host and daslang_static actually consume. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR adjusts the daslang superbuild integration for dasImguiImplot so it only produces the static-embed target, avoiding building a redundant shared “twin” that is not used by superbuild consumers and causes Windows linking/export complications.
Changes:
- Remove the superbuild-time
ADD_MODULE_LIB(... dasModuleImplot ...)shared target creation and related link lines. - Always build only
libDasModuleImplotviaADD_DAS_STATIC_MODULE_LIB(...)when included from a daslang superbuild. - Keep the standalone
.shared_modulebuild path unchanged (still buildsdasModuleImplotwhen not in superbuild mode).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the daslang fat-man gate on its first real (
daslang_static) link: the shared twin of an imgui-dependent module can't link on Windows (needs the dllexport matrix against dasImgui), and nothing ever loads it — in a superbuild the DLL flavor comes from this module's own standalone build. Static half only, matching what an embedded host anddaslang_staticconsume. Same fix as borisbat/dasImgui#219 / borisbat/dasImguiNodeEditor / borisbat/dasVulkan.Validated: full fat-man link + smoke on Windows (
daslang_static, all five externals,rc=0); standalone flow untouched.🤖 Generated with Claude Code