fix(ci): Scoop bucket bump forgot to update the url field - #23
Merged
Conversation
release.yml's jq filter bumped .version and .architecture["64bit"].hash on every release but never touched .architecture["64bit"].url — it stayed pinned to whatever URL was last set by hand (v0.7.1, from the earlier manual bucket fix). The v0.7.2 release bumped version and hash correctly but left url pointing at the v0.7.1 asset, so 'scoop update zt' downloaded the old v0.7.1 binary and hash-checked it against the new v0.7.2 hash: Expected: 8fe1efe0... (real v0.7.2 hash) Actual: 78ce3640... (v0.7.1's hash — the binary it actually got) Every field the manifest pins to a release needs to move together. Manually re-points bucket/zt.json's url at the real v0.7.2 asset right now (this doesn't need a new release, the v0.7.2 binary is already published) and fixes the jq filter to set url alongside version/hash going forward.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release.yml's jq filter bumped .version and .architecture["64bit"].hash on every release but never touched .architecture["64bit"].url — it stayed pinned to whatever URL was last set by hand (v0.7.1, from the earlier manual bucket fix). The v0.7.2 release bumped version and hash correctly but left url pointing at the v0.7.1 asset, so 'scoop update zt' downloaded the old v0.7.1 binary and hash-checked it against the new v0.7.2 hash:
Expected: 8fe1efe0... (real v0.7.2 hash)
Actual: 78ce3640... (v0.7.1's hash — the binary it actually got)
Every field the manifest pins to a release needs to move together. Manually re-points bucket/zt.json's url at the real v0.7.2 asset right now (this doesn't need a new release, the v0.7.2 binary is already published) and fixes the jq filter to set url alongside version/hash going forward.