Skip to content

fix(ci): Scoop bucket bump forgot to update the url field #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
casablanque-code merged 1 commit into from
Aug 2, 2026
Merged

fix(ci): Scoop bucket bump forgot to update the url field #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ jobs:
run: |
VERSION="${GITHUB_REF_NAME#v}"
HASH=$(awk '{print $1}' dist/zt-windows-amd64.exe.sha256)
URL="https://github.com/${GITHUB_REPOSITORY}/releases/download/${GITHUB_REF_NAME}/zt-windows-amd64.exe#/zt.exe"

if [[ ! "$HASH" =~ ^[a-fA-F0-9]{64}$ ]]; then
echo "error: could not read a valid sha256 from dist/zt-windows-amd64.exe.sha256 (got: '$HASH')" >&2
Expand All @@ -71,8 +72,13 @@ jobs:
git fetch origin main
git checkout -B main origin/main

jq --arg version "$VERSION" --arg hash "$HASH" \
'.version = $version | .architecture["64bit"].hash = $hash' \
# Every field the manifest pins to a specific release —
# version, url, hash — must be bumped together. Missing the
# url here once already shipped a bucket that reported the
# new version but downloaded the previous release's binary
# and failed its own hash check.
jq --arg version "$VERSION" --arg url "$URL" --arg hash "$HASH" \
'.version = $version | .architecture["64bit"].url = $url | .architecture["64bit"].hash = $hash' \
bucket/zt.json > bucket/zt.json.tmp
mv bucket/zt.json.tmp bucket/zt.json

Expand Down
2 changes: 1 addition & 1 deletion bucket/zt.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"license": "MIT",
"architecture": {
"64bit": {
"url": "https://github.com/casablanque-code/cfzt/releases/download/v0.7.1/zt-windows-amd64.exe#/zt.exe",
"url": "https://github.com/casablanque-code/cfzt/releases/download/v0.7.2/zt-windows-amd64.exe#/zt.exe",
"hash": "8fe1efe0ab42a1599c03d3479cb24d01d98b8798622439aa92ba50b6cf610ddb"
}
},
Expand Down
Loading