docs(modules): document sidecar services in compose fragments (follow-up to #426) - #429
Merged
Merged
Conversation
Follow-up to #426: the overlay absolutizes a fragment's build.context / build.dockerfile / env_file paths, so a module may declare a whole sidecar service (the raven module's RayFronts container is the first). The paragraph was written alongside #426 but did not land on its branch. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
Test Metrics —
|
| Test | Pass | Fail | Skip | Rate |
|---|---|---|---|---|
| test_colcon_build_gcs | 1 | 0 | 0 | 100% |
| test_colcon_build_ms_airsim | 1 | 0 | 0 | 100% |
| test_colcon_build_robot | 1 | 0 | 0 | 100% |
| test_colcon_test_robot | 1 | 0 | 0 | 100% |
Metrics
| Test | Metric | Value |
|---|---|---|
| test_colcon_build_robot | duration_s | 142.8s |
| test_colcon_test_robot | duration_s | 39.67s |
| test_colcon_build_gcs | duration_s | 65.02s |
| test_colcon_build_ms_airsim | duration_s | 14.8s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #426. Adds the paragraph in
docs/development/modules.mddescribing that a module compose fragment may declare a sidecar service with its ownbuild:section (the overlay absolutizesbuild.context/build.dockerfile/env_file), as theravenmodule does for its RayFronts container. The matching note in thecreate-moduleskill already landed with #426; this paragraph had been written on the wrong checkout.Docs-only; VERSION bumped for the increment gate.
🤖 Generated with Claude Code