fix(metrics): pin prometheus's protobuf feature for process metrics - #258
Merged
TheJokr merged 1 commit intoAug 25, 2026
Merged
Conversation
`process.rs` calls prometheus's `get_value()`, which only exists when prometheus's `protobuf` feature is off, but the feature was never pinned, so any other crate in the graph enabling it (it is a prometheus default) swapped in the protobuf model and broke the build. Pin `protobuf` on and use the `value()` accessor, which is public in that model (`get_value()` lives on the private `proto_ext::MessageFieldExt` trait).
TheJokr
approved these changes
Aug 25, 2026
Merged
dotjs
pushed a commit
that referenced
this pull request
Aug 26, 2026
### Fixed - #258: With `foundations-metrics-backend` enabled, the `process` metrics implementation relied on an accessor in the `prometheus` crate that is not present when the `protobuf` feature is enabled. This change enables the `protobuf` feature in `prometheus` instead and uses a different accessor. - #260: `NativeHistogram`, when scraped in protobuf format, now correctly exposes an upper bound of `f64::INFINITY` rather than `f64::MAX`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
process.rscalls prometheus'sget_value(), which only exists when prometheus'sprotobuffeature is off — but the feature was never pinned, so any other crate in the graph enabling it (it is a prometheus default) swaps in the protobuf model and breaks the build.Pin
protobufon and use thevalue()accessor, which is public in that model (get_value()lives on the privateproto_ext::MessageFieldExttrait).