Avoid contradictory shield material names - #233
Closed
henriquejsza wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #232.
Summary
bucklersmall shieldas the unidentified description for all three matching shield typesThis keeps randomized material names coherent: an unidentified variant is now a
stone small shield, while its identified ordinary form is astone buckler.Testing
make allmake installwooden shielddefinitions before the change, then passed withISSUE_232_REPRO_OKtest/test_obj.lua: passed withOBJECT_ENUM_OKThe later interactive item-use section of
test/test_obj.luawas not used as an automated gate; the repository CI itself builds on Linux, macOS, and Windows.