docs: let the shared styles bring the fonts - #489
Conversation
The shared styles from cpp-linter.github.io now carry the hub's look, fonts included, so Material's Roboto was downloaded and never used.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe MkDocs Material theme configuration disables built-in fonts. A comment notes that the shared stylesheet supplies fonts. ChangesDocumentation theme configuration
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to No actionable merge-blocking issue is established; the documented font fallback is bounded and may be addressed with the shared stylesheet deployment. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Because we do not have preview CI here. let's merge and see how it goes. |
There was a problem hiding this comment.
Should be fine now that cpp-linter/cpp-linter.github.io#67 was merged
cpp-linter/cpp-linter.github.io#67 moved the hub's look (colors, light header and fonts) into the shared stylesheet these docs already load. It is live, so this site now uses the hub's self-hosted fonts. Material's default Roboto is still requested from Google Fonts on every page and never used. This sets `theme.font: false`, as cpp-linter/cpp-linter-action#489 did. Checked that `docs/mkdocs.yml` still parses with `theme.font` set to false. The full docs build needs the Rust bindings, so it runs in CI. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Style** * The documentation site now uses shared font styling rather than the theme’s built-in font. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
cpp-linter/cpp-linter.github.io#67 moves the hub's look (colors, light header, fonts) into the shared stylesheet these docs already load, so this site will match https://cpp-linter.github.io/ without changes of its own.
With the fonts coming from there, Material's default Roboto is downloaded and never used. This sets
theme.font: falseto stop loading it.Merge after cpp-linter/cpp-linter.github.io#67 is deployed; before that, this site would fall back to the system font.
Checked with a local
mkdocs build: the pages no longer request Google Fonts themselves and still loadshared.css.Summary by CodeRabbit