docs: move the site's look into the shared styles - #67
Merged
Merged
Conversation
✅ Deploy Preview for cpp-linter-github-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
2bndy5
reviewed
Sep 25, 2026
The home page redesign put the paper and ink colors, the light header and the fonts in extra.css, which only this site loads. The product docs sites load shared.css, so they kept Material's default indigo header and Roboto and no longer look like the hub they link back to. Move those rules into shared.css unchanged, and import the fonts there so a site gets them without a template of its own. extra.css keeps the rules only this site uses: the merch grid, the readable width for pages without a left navigation, and the comparison and size-chart tables.
shared.css imported the fonts from fonts.googleapis.com. As an @import in a stylesheet that every docs site loads, that request held up the first render on all of them, stalled where Google Fonts is blocked, and sent each visitor's IP address to Google. The latin and latin-ext subsets of the three variable fonts (Instrument Sans, Bricolage Grotesque and JetBrains Mono: ten woff2 files, 274 KB) now live in docs/fonts with their OFL licenses, and shared.css declares them with @font-face. The URLs are relative to shared.css, so the other docs sites get the fonts from cpp-linter.github.io as well. This site preloads the latin files for text and headings instead of linking Google Fonts.
shenxianpeng
force-pushed
the
feature/share-docs-theme
branch
from
September 25, 2026 06:48
eee5d7f to
2133bbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The home page redesign (#65) gave the site its paper and ink colors, a light header and new fonts (Instrument Sans, Bricolage Grotesque, JetBrains Mono), but put them in
extra.css, which only this site loads. The docs sites loadshared.css(#64), so https://cpp-linter.github.io/cpp-linter-action/ and the others still have Material's indigo header and Roboto.This moves those rules from
extra.cssintoshared.cssunchanged, so all four docs sites pick them up with no change of their own:The fonts are self-hosted rather than imported from Google Fonts. An
@importof fonts.googleapis.com in a stylesheet every docs site loads would hold up the first render on all of them, stall where Google Fonts is blocked, and send each visitor's IP address to Google.docs/fonts/has the latin and latin-ext subsets of the three variable fonts (ten woff2 files, 274 KB; a page downloads only the files it uses, about 135 KB for plain English text) and their OFL licenses.shared.cssdeclares them with@font-faceand URLs relative to itself, so the other docs sites fetch them from cpp-linter.github.io too; GitHub Pages sendsAccess-Control-Allow-Origin: *, so a docs site previewed locally loads them as well. This site preloads the latin files for text and headings.extra.csskeeps what only this site uses: the merch grid, the readable width for pages without a left navigation, and the comparison and size-chart tables.Checked
Self-hosted fonts: the home page and a copy of the cpp-linter-action and cpp-linter (Sphinx) docs pages pointed at the local
shared.cssmake no request to Google for these fonts, load them from/fonts/once each, and render in Instrument Sans, Bricolage Grotesque and JetBrains Mono.mkdocs build --strictand the pre-commit hooks pass.Local build: the computed styles of
/getting-started/(background, header, headings, body text, code, links, search) match the live site exactly.The new
shared.cssswapped into the live pages of all four docs sites, light and dark: each gets the paper background, the light header, the fonts and the warm code blocks, with nothing broken, including the Sphinx site.Once this is deployed, the docs sites can set
theme.font: falseso Material stops loading Roboto they no longer use; cpp-linter-action does in its own PR.