F1 Item 1: Remove processPriority field (closes #35) - #51
Merged
Conversation
The processPriority field on ThrottleProfile was typed and stored in settings but no engine code ever called SetPriorityClass (Windows), nice/renice (POSIX), or any OS-level priority API. The UI rendered the configured value, giving a false impression that the OS scheduler was being adjusted. Per the F1 (#35) decision Item 1 = C, the field is removed from: - shared ThrottleProfile type and default profile literals - engine throttle module readers - settings persistence path - UI throttle render - spec §5.5 F1 Item 2 (WebSocket browser event delivery) is being planned separately and is NOT touched here — @hono/node-ws stays in packages/engine/package.json until that plan lands. Closes #35 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
F1 (#35) decision Item 1 = C) Remove. The
processPriorityfield onThrottleProfilewas typed and stored but no code ever applied OS-level priority. UI rendered the configured value giving a false impression.Removes the field from:
shared/throttle.ts— type + default profile literalsF1 Item 2 explicitly out of scope
The WebSocket browser delivery decision (Item 2) is being planned separately and is NOT part of this MR.
@hono/node-wsstays inpackages/engine/package.jsonuntil that planning round lands a follow-up.Test plan
grep -r processPriority packages/ docs/returns emptyCloses #35