Skip to content

F1 Item 1: Remove processPriority field (closes #35) #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
curtyo18 merged 1 commit into from
May 17, 2026
Merged

F1 Item 1: Remove processPriority field (closes #35) #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions docs/superpowers/plans/2026-04-25-file-organizer-implementation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,7 +872,6 @@ export interface ThrottleProfile {
networkHashWorkers: number;
readChunkBytes: number;
interChunkSleepMs: number;
processPriority: 'below-normal' | 'normal' | 'high';
maxOpenFiles: number;
}

Expand All @@ -890,7 +889,6 @@ export const DEFAULT_THROTTLE_PROFILES: Record<ThrottleProfileName, ThrottleProf
networkHashWorkers: 1,
readChunkBytes: 256 * 1024,
interChunkSleepMs: 5,
processPriority: 'below-normal',
maxOpenFiles: 4,
},
balanced: {
Expand All @@ -899,7 +897,6 @@ export const DEFAULT_THROTTLE_PROFILES: Record<ThrottleProfileName, ThrottleProf
networkHashWorkers: 1,
readChunkBytes: 1024 * 1024,
interChunkSleepMs: 1,
processPriority: 'normal',
maxOpenFiles: 16,
},
'full-send': {
Expand All @@ -908,7 +905,6 @@ export const DEFAULT_THROTTLE_PROFILES: Record<ThrottleProfileName, ThrottleProf
networkHashWorkers: 2,
readChunkBytes: 4 * 1024 * 1024,
interChunkSleepMs: 0,
processPriority: 'normal',
maxOpenFiles: 64,
},
};
Expand All @@ -929,7 +925,6 @@ export interface ThrottleProfile {
networkHashWorkers: number;
readChunkBytes: number;
interChunkSleepMs: number;
processPriority: 'below-normal' | 'normal' | 'high';
maxOpenFiles: number;
}

Expand All @@ -948,7 +943,6 @@ export function defaultThrottleProfiles(cpuCount: number): Record<ThrottleProfil
networkHashWorkers: 1,
readChunkBytes: 256 * 1024,
interChunkSleepMs: 5,
processPriority: 'below-normal',
maxOpenFiles: 4,
},
balanced: {
Expand All @@ -957,7 +951,6 @@ export function defaultThrottleProfiles(cpuCount: number): Record<ThrottleProfil
networkHashWorkers: 1,
readChunkBytes: 1024 * 1024,
interChunkSleepMs: 1,
processPriority: 'normal',
maxOpenFiles: 16,
},
'full-send': {
Expand All @@ -966,7 +959,6 @@ export function defaultThrottleProfiles(cpuCount: number): Record<ThrottleProfil
networkHashWorkers: 2,
readChunkBytes: 4 * 1024 * 1024,
interChunkSleepMs: 0,
processPriority: 'normal',
maxOpenFiles: 64,
},
};
Expand Down Expand Up @@ -9254,7 +9246,7 @@ export function Throttle() {
return (
<div key={name} style="margin-bottom:12px">
<strong>{name}</strong>
<div class="muted">workers: local {p.localHashWorkers} / nas {p.networkHashWorkers} · chunk {p.readChunkBytes}B · sleep {p.interChunkSleepMs}ms · priority {p.processPriority}</div>
<div class="muted">workers: local {p.localHashWorkers} / nas {p.networkHashWorkers} · chunk {p.readChunkBytes}B · sleep {p.interChunkSleepMs}ms</div>
<input type="number" min={1} max={32} value={p.localHashWorkers} onInput={(e) => {
const v = parseInt((e.target as HTMLInputElement).value, 10);
setSettings({
Expand Down
1 change: 0 additions & 1 deletion docs/superpowers/specs/2026-04-25-file-organizer-design.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,6 @@ Three profiles, hot-swappable mid-scan:
| NAS hash workers | 1 | 1 | 2 |
| Read chunk size | 256 KB | 1 MB | 4 MB |
| Inter-chunk sleep (ms) | 5 | 1 | 0 |
| Process priority | below normal | normal | normal |
| Max open files | 4 | 16 | 64 |

NAS workers are capped low even on `full-send` because the bottleneck is network bandwidth and concurrent reads thrash mechanical disks.
Expand Down
4 changes: 0 additions & 4 deletions packages/shared/src/throttle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ export interface ThrottleProfile {
networkHashWorkers: number;
readChunkBytes: number;
interChunkSleepMs: number;
processPriority: 'below-normal' | 'normal' | 'high';
maxOpenFiles: number;
}

Expand All @@ -25,7 +24,6 @@ export function defaultThrottleProfiles(cpuCount: number): Record<ThrottleProfil
networkHashWorkers: 1,
readChunkBytes: 256 * 1024,
interChunkSleepMs: 5,
processPriority: 'below-normal',
maxOpenFiles: 4,
},
balanced: {
Expand All @@ -34,7 +32,6 @@ export function defaultThrottleProfiles(cpuCount: number): Record<ThrottleProfil
networkHashWorkers: 1,
readChunkBytes: 1024 * 1024,
interChunkSleepMs: 1,
processPriority: 'normal',
maxOpenFiles: 16,
},
'full-send': {
Expand All @@ -43,7 +40,6 @@ export function defaultThrottleProfiles(cpuCount: number): Record<ThrottleProfil
networkHashWorkers: 2,
readChunkBytes: 4 * 1024 * 1024,
interChunkSleepMs: 0,
processPriority: 'normal',
maxOpenFiles: 64,
},
};
Expand Down
15 changes: 0 additions & 15 deletions packages/ui/src/routes/throttle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,21 +389,6 @@ function ProfileCard({ profile, onChange }: ProfileCardProps) {
onInput={(e) => onChange({ maxOpenFiles: num(e) })}
/>
</ProfileField>
<ProfileField label="Process priority">
<select
value={profile.processPriority}
onChange={(e) =>
onChange({
processPriority: (e.target as HTMLSelectElement)
.value as ThrottleProfile['processPriority'],
})
}
>
<option value="below-normal">below-normal</option>
<option value="normal">normal</option>
<option value="high">high</option>
</select>
</ProfileField>
</div>
);
}
Expand Down
Loading